Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3786)

Unified Diff: chrome/test/data/extensions/api_test/webrequest/test_blocking.js

Issue 8669014: Fix a bug where redirect chain gets lost on process swap. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: conditional disabling Created 9 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/test/data/extensions/api_test/webrequest/test_blocking.js
diff --git a/chrome/test/data/extensions/api_test/webrequest/test_blocking.js b/chrome/test/data/extensions/api_test/webrequest/test_blocking.js
index a0e6d6f8d36222de5b471948d618f50a31982850..6829044cf885a487c32c5f07834899070f8223e5 100644
--- a/chrome/test/data/extensions/api_test/webrequest/test_blocking.js
+++ b/chrome/test/data/extensions/api_test/webrequest/test_blocking.js
@@ -126,9 +126,6 @@ runTests([
// Navigates to a page with a blocking handler that redirects to a different
// page.
- // TODO(mpcomplete): We should see an onBeforeRedirect as well, but our
- // process switching logic cancels the original redirect request and
- // starts a new one instead. See http://crbug.com/79520.
function complexLoadRedirected() {
expect(
[ // events
@@ -140,14 +137,15 @@ runTests([
},
retval: {redirectUrl: getURL("simpleLoad/a.html")}
},
- { label: "onErrorOccurred-1",
- event: "onErrorOccurred",
+ { label: "onBeforeRedirect",
+ event: "onBeforeRedirect",
details: {
url: getURL("complexLoad/a.html"),
+ redirectUrl: getURL("simpleLoad/a.html"),
+ statusLine: "",
+ statusCode: -1,
fromCache: false,
- error: "net::ERR_ABORTED"
- // Request to chrome-extension:// url has no IP.
- }
+ },
},
{ label: "onBeforeRequest-2",
event: "onBeforeRequest",
@@ -178,7 +176,7 @@ runTests([
},
],
[ // event order
- ["onBeforeRequest-1", "onErrorOccurred-1", "onBeforeRequest-2",
+ ["onBeforeRequest-1", "onBeforeRedirect", "onBeforeRequest-2",
"onResponseStarted", "onCompleted"],
],
{}, // filter
« no previous file with comments | « chrome/test/data/extensions/api_test/webrequest/framework.js ('k') | content/browser/renderer_host/global_request_id.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698