Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(294)

Issue 8669010: Revert 111270 - Part 1 of work to do user sign in based on OAuth2: (Closed)

Created:
9 years, 1 month ago by Albert Bodenhamer
Modified:
9 years, 1 month ago
Reviewers:
Munjal (Google)
CC:
chromium-reviews, cbentzel+watch_chromium.org, darin-cc_chromium.org, Paweł Hajdan Jr.
Visibility:
Public.

Description

Revert 111270 - Part 1 of work to do user sign in based on OAuth2: - Add a couple of more flow methods to GaiaAuthFetcher. - Add a new fetcher class to get a new access token from refresh token. - Full set o tests. Review URL: http://codereview.chromium.org/8632005 TBR=munjal@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=111277

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -1068 lines) Patch
M chrome/chrome_common.gypi View 1 chunk +0 lines, -3 lines 0 comments Download
M chrome/chrome_tests.gypi View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/common/net/gaia/gaia_auth_consumer.h View 1 chunk +0 lines, -5 lines 0 comments Download
M chrome/common/net/gaia/gaia_auth_fetcher.h View 11 chunks +1 line, -60 lines 0 comments Download
M chrome/common/net/gaia/gaia_auth_fetcher.cc View 18 chunks +3 lines, -233 lines 0 comments Download
M chrome/common/net/gaia/gaia_auth_fetcher_unittest.cc View 6 chunks +0 lines, -225 lines 0 comments Download
M chrome/common/net/gaia/gaia_constants.h View 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/common/net/gaia/gaia_constants.cc View 1 chunk +3 lines, -5 lines 0 comments Download
M chrome/common/net/gaia/gaia_urls.h View 2 chunks +0 lines, -10 lines 0 comments Download
M chrome/common/net/gaia/gaia_urls.cc View 3 chunks +0 lines, -35 lines 0 comments Download
M chrome/common/net/gaia/google_service_auth_error.h View 1 chunk +0 lines, -3 lines 0 comments Download
D chrome/common/net/gaia/oauth2_access_token_consumer.h View 1 chunk +0 lines, -23 lines 0 comments Download
D chrome/common/net/gaia/oauth2_access_token_fetcher.h View 1 chunk +0 lines, -94 lines 0 comments Download
D chrome/common/net/gaia/oauth2_access_token_fetcher.cc View 1 chunk +0 lines, -189 lines 0 comments Download
D chrome/common/net/gaia/oauth2_access_token_fetcher_unittest.cc View 1 chunk +0 lines, -180 lines 0 comments Download

Messages

Total messages: 1 (0 generated)
Albert Bodenhamer
9 years, 1 month ago (2011-11-23 01:40:43 UTC) #1

          

Powered by Google App Engine
This is Rietveld 408576698