Issue 8669007: Fix leaks from a unit test added in r111239.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 8669007: Fix leaks from a unit test added in r111239. (Closed)

Created:
9 years, 1 month ago by simonmorris

Modified:
9 years, 1 month ago

Reviewers:
Sergey Ulanov, dhollowa

CC:
chromium-reviews, jamiewalch+watch_chromium.org, hclam+watch_chromium.org, simonmorris+watch_chromium.org, wez+watch_chromium.org, garykac+watch_chromium.org, lambroslambrou+watch_chromium.org, Paweł Hajdan Jr., sergeyu+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Fix leaks from a unit test added in r111239. R=sergeyu CC=chromoting,dhollowa Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=111309

Patch Set 1 #

Created: 9 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+9 lines, -3 lines)			Patch
	M	remoting/host/log_to_server_unittest.cc	View		4 chunks	+9 lines, -3 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Sergey Ulanov

LGTM R= and CC= are not necessary the commit message :)

9 years, 1 month ago (2011-11-23 01:35:38 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/simonmorris@chromium.org/8669007/1

9 years, 1 month ago (2011-11-23 01:45:41 UTC) #2

commit-bot: I haz the power

Try job failure for 8669007-1 (retry) on win_rel for step "ui_tests". It's a second try, ...

9 years, 1 month ago (2011-11-23 03:37:10 UTC) #3

dhollowa

9 years, 1 month ago (2011-11-23 03:45:54 UTC) #4

The CQ failure looks unrelated.  I landed this to clear the memory bots.

Expand Messages | Collapse Messages