Issue 8667009: Work around a bug in gyp triggered by webkit_appcache.gypi.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 8667009: Work around a bug in gyp triggered by webkit_appcache.gypi. (Closed)

Created:
9 years, 1 month ago by Dirk Pranke

Modified:
9 years, 1 month ago

Reviewers:
tony

CC:
chromium-reviews, michaeln, darin-cc_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Work around a bug in gyp triggered by webkit_appcache.gypi. The bug seems to be showing up on the chromium build.webkit.org bots where we're generating two different versions of webkit_appcache.target.mk and the second one is overwriting the first, but is being considered to not be "part of all". As a result, DumpRenderTree is no longer being built by "make all". TBR=tony@chromium.org BUG=https://bugs.webkit.org/show_bug.cgi?id=73004 TEST=DRT builds on Linux Release bot on build.webkit.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=111325

Patch Set 1 #

Patch Set 2 : refactor again so that the mac build doesn't pull in the webkit dependency #

Created: 9 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+7 lines, -3 lines)			Patch
	M	webkit/appcache/webkit_appcache.gypi	View	1	1 chunk	+7 lines, -3 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

tony

LG, but please file a chromium bug to track this and reference it in the ...

9 years, 1 month ago (2011-11-23 07:59:24 UTC) #2

Dirk Pranke

9 years, 1 month ago (2011-11-23 19:25:56 UTC) #3

On 2011/11/23 07:59:24, tony wrote:
> LG, but please file a chromium bug to track this and reference it in the gypi
> file.

Will do. 

After thinking about this further, I'm not sure if this is something that only
breaks because it's a circular reference back to the main gyp file, and hence is
less of a problem because circular references are bad, or if it's a problem for
target generation generally. Will keep looking.

Expand Messages | Collapse Messages