Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(90)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 8667008: Fix python scripts in src/build/ (Closed)

Created:
9 years, 1 month ago by M-A Ruel
Modified:
9 years ago
Reviewers:
michaelbai
CC:
chromium-reviews, stuartmorgan+watch_chromium.org, Alexander Potapenko, Timur Iskhodzhanov, John Grabowski
Visibility:
Public.

Description

Fix python scripts in src/build/ Make sure that: - shebang is only present for executable files - shebang is #!/usr/bin/env python - __main__ is only present for executable files - file's executable bit is coherent Also fix EOF LF to be only one. TBR=michaelbai@chromium.org BUG=105108 TEST= Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=111385

Patch Set 1 #

Patch Set 2 : . #

Patch Set 3 : . #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+120 lines, -117 lines) Patch
M build/android/android_commands.py View 1 chunk +1 line, -1 line 0 comments Download
M build/android/base_test_runner.py View 1 chunk +0 lines, -1 line 0 comments Download
M build/android/cmd_helper.py View 1 chunk +0 lines, -1 line 0 comments Download
M build/android/debug_info.py View 1 chunk +0 lines, -1 line 0 comments Download
M build/android/emulator.py View 1 chunk +1 line, -1 line 0 comments Download
M build/android/flag_changer.py View 1 chunk +0 lines, -1 line 0 comments Download
M build/android/lighttpd_server.py View 1 chunk +1 line, -1 line 2 comments Download
M build/android/perf_tests_helper.py View 1 chunk +0 lines, -1 line 0 comments Download
M build/android/run_tests.py View 1 chunk +1 line, -1 line 0 comments Download
M build/android/run_tests_helper.py View 1 chunk +0 lines, -1 line 0 comments Download
M build/android/single_test_runner.py View 1 chunk +0 lines, -1 line 0 comments Download
M build/android/test_package.py View 1 chunk +0 lines, -1 line 0 comments Download
M build/android/test_package_executable.py View 1 chunk +0 lines, -1 line 0 comments Download
M build/android/test_result.py View 1 chunk +0 lines, -1 line 0 comments Download
M build/android/valgrind_tools.py View 1 chunk +0 lines, -1 line 0 comments Download
M build/compiler_version.py View 1 1 chunk +1 line, -2 lines 0 comments Download
M build/dir_exists.py View 1 chunk +8 lines, -3 lines 0 comments Download
M build/download_nacl_toolchains.py View 2 chunks +3 lines, -2 lines 0 comments Download
M build/escape_unicode.py View 4 chunks +4 lines, -3 lines 0 comments Download
M build/extract_from_cab.py View 1 chunk +23 lines, -15 lines 0 comments Download
M build/linux/rewrite_dirs.py View 1 2 4 chunks +4 lines, -1 line 0 comments Download
M build/mac/change_mach_o_flags.py View 1 2 2 chunks +71 lines, -72 lines 0 comments Download
M build/scan_sources.py View 2 chunks +1 line, -2 lines 0 comments Download
M build/scan_sources_test.py View 2 chunks +1 line, -2 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
M-A Ruel
Context: I'm going to add a presubmit check to enforce some of these rules. http://codereview.chromium.org/8667008/diff/3001/build/android/lighttpd_server.py ...
9 years, 1 month ago (2011-11-23 03:17:44 UTC) #1
michaelbai
LGTM for the android part. Besides upcoming presubmit check, do you have the a page ...
9 years ago (2011-11-23 17:55:07 UTC) #2
M-A Ruel
On 2011/11/23 17:55:07, michaelbai wrote: > LGTM for the android part. > > Besides upcoming ...
9 years ago (2011-11-23 17:58:37 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/maruel@chromium.org/8667008/3001
9 years ago (2011-11-23 18:02:27 UTC) #4
commit-bot: I haz the power
9 years ago (2011-11-23 19:13:45 UTC) #5 
Change committed as 111385

Powered by Google App Engine
This is Rietveld 408576698