chrome/common/chrome_content_client.cc - Issue 8667006: Extract similar code into SetJobObjectAsKillOnJobClose()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/common/chrome_content_client.cc

Issue 8667006: Extract similar code into SetJobObjectAsKillOnJobClose() (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 9 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/common/chrome_content_client.cc

diff --git a/chrome/common/chrome_content_client.cc b/chrome/common/chrome_content_client.cc

index 65b004b3ede042d7c5f9f3ceb30305b025eaa03f..6a4ad8ae3664021c85b6e1098dc898a4b546b150 100644

--- a/chrome/common/chrome_content_client.cc

+++ b/chrome/common/chrome_content_client.cc

@@ -229,11 +229,7 @@ bool LoadFlashBroker(const FilePath& plugin_path, CommandLine* cmd_line) {

// terminates the job object is destroyed (by the OS) and the flash broker

// is terminated.

HANDLE job = ::CreateJobObjectW(NULL, NULL);

- JOBOBJECT_EXTENDED_LIMIT_INFORMATION job_limits = {0};

- job_limits.BasicLimitInformation.LimitFlags =

- JOB_OBJECT_LIMIT_KILL_ON_JOB_CLOSE;

- if (::SetInformationJobObject(job, JobObjectExtendedLimitInformation,

- &job_limits, sizeof(job_limits))) {

+ if (SetJobObjectAsKillOnJobClose(job)) {

::AssignProcessToJobObject(job, process);

// Yes, we are leaking the object here. Read comment above.

} else {