Extract similar code into SetJobObjectAsKillOnJobClose()

Extract similar code into SetJobObjectAsKillOnJobClose()

For now, Chromium have five same code in various place to handle JobObject
as KILL_ON_JOB_CLOSE.
This change provide a common utility function to be used by them.

BUG=n/a
TEST=n/a; run existing unit tests because this is just a refactoring change

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=111441

[Takashi Toyoshima, 2011-11-23 02:48:18]

Hi, everyone.

This is a change to refactoring on JobObject in Win32.
It's based on discussion at http://codereview.chromium.org/8633004/.

I add Evan and Marc-Antoine because this change spread over src/base.
I'd like to get OWNERS LGTM from Evan or Marc-Antoine for src/base,
and from Paweł for */test. I think anyone of you is OK for chrome/common.

Thanks,

[M-A Ruel, 2011-11-23 03:01:35]

lgtm

http://codereview.chromium.org/8667006/diff/1/base/process_util_win.cc
File base/process_util_win.cc (right):

http://codereview.chromium.org/8667006/diff/1/base/process_util_win.cc#newcod...
base/process_util_win.cc:312: if (0 == SetInformationJobObject(job_object,
style nit: (optional)

return 0 != SetInformationJobObject(
    job_object,
    JobObjectExtendedLimitInformation,
    &limit_info,
    sizeof(limit_info)))

[Takashi Toyoshima, 2011-11-23 04:36:54]

Thanks Marc-Antoine,
Fixed style issue.
I'll land this change after one more review by Paweł's on test stuff.

http://codereview.chromium.org/8667006/diff/1/base/process_util_win.cc
File base/process_util_win.cc (right):

http://codereview.chromium.org/8667006/diff/1/base/process_util_win.cc#newcod...
base/process_util_win.cc:312: if (0 == SetInformationJobObject(job_object,
On 2011/11/23 03:01:40, Marc-Antoine Ruel wrote:
> style nit: (optional)
> 
> return 0 != SetInformationJobObject(
>     job_object,
>     JobObjectExtendedLimitInformation,
>     &limit_info,
>     sizeof(limit_info)))

Done.

[Paweł Hajdan Jr., 2011-11-23 10:05:28]

LGTM, thanks.

[commit-bot: I haz the power, 2011-11-23 13:34:19]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/toyoshim@chromium.org/8667006/4001

[commit-bot: I haz the power, 2011-11-23 13:57:59]

Try job failure for 8667006-4001 (retry) on win_rel for step "compile" (clobber
build).
It's a second try, previously, step "compile" failed.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&nu...

[commit-bot: I haz the power, 2011-11-23 14:08:07]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/toyoshim@chromium.org/8667006/9001

[commit-bot: I haz the power, 2011-11-23 14:28:52]

Try job failure for 8667006-9001 (retry) on win_rel for step "compile" (clobber
build).
It's a second try, previously, step "compile" failed.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&nu...

[commit-bot: I haz the power, 2011-11-23 15:47:06]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/toyoshim@chromium.org/8667006/9003

[commit-bot: I haz the power, 2011-11-23 16:06:52]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/toyoshim@chromium.org/8667006/13002

[commit-bot: I haz the power, 2011-11-23 17:16:20]

Try job failure for 8667006-13002 (retry) on mac_rel for step "media_unittests".
It's a second try, previously, step "media_unittests" failed.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=mac_rel&nu...

[M-A Ruel, 2011-11-23 17:19:09]

On 2011/11/23 17:16:20, I haz the power (commit-bot) wrote:
> Try job failure for 8667006-13002 (retry) on mac_rel for step
"media_unittests".
> It's a second try, previously, step "media_unittests" failed.
>
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=mac_rel&nu...

Looks unrelated, queuing up again.

[commit-bot: I haz the power, 2011-11-23 17:19:38]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/toyoshim@chromium.org/8667006/13002

[commit-bot: I haz the power, 2011-11-23 18:22:40]

Try job failure for 8667006-13002 (retry) on mac_rel for step "compile" (clobber
build).
It's a second try, previously, step "compile" failed.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=mac_rel&nu...

[Takashi Toyoshima, 2011-11-23 23:33:28]

OK, I use dcommit.