Fix Bind usage in imageburner.

Remove NewRunnableFunction in imageburner.

BUG=chromium-os:22024
TEST=compiles, tests run.

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=111468

[achuithb, 2011-11-22 23:31:08]

Please review, thanks!

[csilv, 2011-11-23 01:39:02]

http://codereview.chromium.org/8667001/diff/1003/chrome/browser/ui/webui/chro...
File chrome/browser/ui/webui/chromeos/imageburner/imageburner_ui.cc (left):

http://codereview.chromium.org/8667001/diff/1003/chrome/browser/ui/webui/chro...
chrome/browser/ui/webui/chromeos/imageburner/imageburner_ui.cc:162: }
As discussed in http://codereview.chromium.org/8113018/, not necessary.  I
recommend reverting this section.

http://codereview.chromium.org/8667001/diff/1003/chrome/browser/ui/webui/chro...
File chrome/browser/ui/webui/chromeos/imageburner/imageburner_ui.cc (right):

http://codereview.chromium.org/8667001/diff/1003/chrome/browser/ui/webui/chro...
chrome/browser/ui/webui/chromeos/imageburner/imageburner_ui.cc:367:
base::Bind(&WebUIHandlerTaskProxy::CreateImageDir, task));
You'll still want to use task.get() here.

http://codereview.chromium.org/8667001/diff/1003/chrome/browser/ui/webui/chro...
chrome/browser/ui/webui/chromeos/imageburner/imageburner_ui.cc:384:
base::Bind(&WebUIHandlerTaskProxy::OnImageDirCreated, task, success));
task.get()

[achuithb, 2011-11-23 19:43:28]

PTAL

http://codereview.chromium.org/8667001/diff/1003/chrome/browser/ui/webui/chro...
File chrome/browser/ui/webui/chromeos/imageburner/imageburner_ui.cc (left):

http://codereview.chromium.org/8667001/diff/1003/chrome/browser/ui/webui/chro...
chrome/browser/ui/webui/chromeos/imageburner/imageburner_ui.cc:162: }
On 2011/11/23 01:39:02, csilv wrote:
> As discussed in http://codereview.chromium.org/8113018/, not necessary.  I
> recommend reverting this section.

Done.

http://codereview.chromium.org/8667001/diff/1003/chrome/browser/ui/webui/chro...
File chrome/browser/ui/webui/chromeos/imageburner/imageburner_ui.cc (right):

http://codereview.chromium.org/8667001/diff/1003/chrome/browser/ui/webui/chro...
chrome/browser/ui/webui/chromeos/imageburner/imageburner_ui.cc:367:
base::Bind(&WebUIHandlerTaskProxy::CreateImageDir, task));
On 2011/11/23 01:39:02, csilv wrote:
> You'll still want to use task.get() here.

Done.

http://codereview.chromium.org/8667001/diff/1003/chrome/browser/ui/webui/chro...
chrome/browser/ui/webui/chromeos/imageburner/imageburner_ui.cc:384:
base::Bind(&WebUIHandlerTaskProxy::OnImageDirCreated, task, success));
On 2011/11/23 01:39:02, csilv wrote:
> task.get()

Done.

[csilv, 2011-11-23 22:42:13]

lgtm

http://codereview.chromium.org/8667001/diff/7001/chrome/browser/ui/webui/chro...
File chrome/browser/ui/webui/chromeos/imageburner/imageburner_ui.cc (right):

http://codereview.chromium.org/8667001/diff/7001/chrome/browser/ui/webui/chro...
chrome/browser/ui/webui/chromeos/imageburner/imageburner_ui.cc:382: task.get(),
success));
nit: align parameters... (ie: align 'task.get()' with '&WebUIHandler...')

[commit-bot: I haz the power, 2011-11-23 23:35:31]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/achuith@chromium.org/8667001/10001

[commit-bot: I haz the power, 2011-11-24 01:10:59]

Change committed as 111468