Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1244)

Unified Diff: content/browser/intents/intent_injector.h

Issue 8666013: Add a public content/ interface for intents. Use it. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: For try servers. Created 9 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/intents/intent_injector.h
diff --git a/content/browser/intents/intent_injector.h b/content/browser/intents/intent_injector.h
index 5f2375ca0df623662c6a7c09a9acd6fcffe5c7ca..919b80ae2b47c4bf81c991f6fba2179bbfc5b846 100644
--- a/content/browser/intents/intent_injector.h
+++ b/content/browser/intents/intent_injector.h
@@ -40,8 +40,9 @@ class CONTENT_EXPORT IntentInjector : public TabContentsObserver {
// Sets the intent data to be injected. Call after the user has selected a
// service to pass the intent data to that service.
- // |source_tab| is a sender to use to communicate to the source tab. Takes
- // ownership of |source_tab|.
+ // |source_tab| is a sender to use to communicate to the source tab. The
+ // caller must ensure that SourceTabContentsDestroyed is called when this
+ // object becomes unusable.
// |intent| is the intent data from the source
// |intent_id| is the ID assigned to the intent invocation from the source
// context.
@@ -62,8 +63,8 @@ class CONTENT_EXPORT IntentInjector : public TabContentsObserver {
// Source intent data provided by caller.
scoped_ptr<webkit_glue::WebIntentData> source_intent_;
- // Message forwarder to the tab invoking the intent.
- scoped_ptr<IPC::Message::Sender> source_tab_;
+ // Weak pointer to the message forwarder to the tab invoking the intent.
+ IPC::Message::Sender* source_tab_;
// Unique ID assigned to the intent by the source tab.
int intent_id_;
« no previous file with comments | « chrome/browser/ui/intents/web_intent_picker_controller_browsertest.cc ('k') | content/browser/intents/intent_injector.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698