Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3787)

Unified Diff: chrome/browser/ui/intents/web_intent_picker_controller.h

Issue 8666013: Add a public content/ interface for intents. Use it. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Fix IntentInjector; use TCO::tab_contents() Created 9 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/intents/web_intent_picker_controller.h
diff --git a/chrome/browser/ui/intents/web_intent_picker_controller.h b/chrome/browser/ui/intents/web_intent_picker_controller.h
index 64db33336317d3102ccc961188e7d3ffebbc5fac..8d02d44514a55a90a46adea272ce399cdc3b601e 100644
--- a/chrome/browser/ui/intents/web_intent_picker_controller.h
+++ b/chrome/browser/ui/intents/web_intent_picker_controller.h
@@ -24,6 +24,10 @@ class TabContentsWrapper;
class WebIntentPicker;
class WebIntentPickerFactory;
+namespace content {
+class IntentsHost;
+}
+
namespace webkit_glue {
struct WebIntentServiceData;
}
@@ -38,14 +42,9 @@ class WebIntentPickerController : public content::NotificationObserver,
WebIntentPickerFactory* factory);
virtual ~WebIntentPickerController();
- // Sets the intent data for which this picker was created. The picker will
- // copy and hold this data until the user has made a service selection.
- // |routing_id| is the IPC routing ID of the source renderer.
- // |intent| is the intent data as created by the client content.
- // |intent_id| is the ID assigned by the source renderer.
- void SetIntent(int routing_id,
- const webkit_glue::WebIntentData& intent,
- int intent_id);
+ // Sets the intent data and return pathway handler object for which
+ // this picker was created. The picker takes ownership of this object.
James Hawkins 2011/11/29 02:57:55 s/this object/intents_host/ Probably document it
Greg Billock 2011/11/29 19:18:16 Done.
+ void SetIntentsHost(content::IntentsHost* intents_host);
// Shows the web intent picker for |browser|, given the intent
// |action| and MIME-type |type|.
@@ -118,15 +117,9 @@ class WebIntentPickerController : public content::NotificationObserver,
// A count of the outstanding asynchronous calls.
int pending_async_count_;
- // The routing id of the renderer which launched the intent. Should be the
- // renderer associated with the TabContents which owns this object.
- int routing_id_;
-
- // The intent data from the client.
- webkit_glue::WebIntentData intent_;
-
- // The intent ID assigned to this intent by the renderer.
- int intent_id_;
+ // The routing object for the renderer which launched the intent.
+ // Contains the intent data and a way to signal back to the client page.
+ scoped_ptr<content::IntentsHost> intents_host_;
// Weak pointer to the tab servicing the intent. Remembered in order to
// close it when a reply is sent.

Powered by Google App Engine
This is Rietveld 408576698