Issue 8666005: Add snapshotting support to about:profiler.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 8666005: Add snapshotting support to about:profiler. (Closed)

Created:
9 years ago by eroman

Modified:
9 years ago

Reviewers:
jar (doing other things)

CC:
chromium-reviews, arv (Not doing code reviews)

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Created: 9 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+364 lines, -44 lines)			Patch
	M	chrome/browser/resources/profiler.html	View		3 chunks	+21 lines, -1 line	0 comments	Download
	M	chrome/browser/resources/profiler.js	View	1	19 chunks	+343 lines, -43 lines	0 comments	Download

Total messages: 4 (0 generated)

jar (doing other things)

LGTM Great work! The big TODO is to think through how we handle a local ...

9 years ago (2011-11-23 01:38:21 UTC) #2

eroman

Thanks for the review. I added a TODO explaining the flaw in the current implementation ...

9 years ago (2011-11-23 01:42:48 UTC) #3

lgtm