Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(174)

Issue 8665013: Fix many* python scripts in src/ (Closed)

Created:
9 years, 1 month ago by M-A Ruel
Modified:
9 years, 1 month ago
Reviewers:
Jamie
CC:
chromium-reviews, jamiewalch+watch_chromium.org, hclam+watch_chromium.org, simonmorris+watch_chromium.org, wez+watch_chromium.org, tfarina, amit, apatrick_chromium, garykac+watch_chromium.org, lambroslambrou+watch_chromium.org, pam+watch_chromium.org, brettw-cc_chromium.org, robertshield, sergeyu+watch_chromium.org, dhollowa
Visibility:
Public.

Description

Fix many* python scripts in src/ Make sure that: - shebang is only present for executable files - shebang is #!/usr/bin/env python - __main__ is only present for executable files - file's executable bit is coherent Also fix EOF LF to be only one. * Do not fix them all at once otherwise the CL would be too large. TBR=jamiewalch@chromium.org BUG=105108 TEST= Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=111427

Patch Set 1 #

Patch Set 2 : . #

Patch Set 3 : Removed chrome_frame/tools/test/page_cycler/cf_cycler.py #

Unified diffs Side-by-side diffs Delta from patch set Stats (+281 lines, -228 lines) Patch
M base/PRESUBMIT.py View 1 chunk +0 lines, -1 line 0 comments Download
M chrome_frame/combine_libs.py View 2 chunks +4 lines, -2 lines 0 comments Download
M chrome_frame/tools/helper_shutdown.py View 2 chunks +8 lines, -4 lines 0 comments Download
M chrome_frame/tools/smoke_test.py View 1 chunk +5 lines, -3 lines 0 comments Download
M gpu/command_buffer/build_gles2_cmd_buffer.py View 1 2 chunks +5 lines, -4 lines 0 comments Download
M jingle/PRESUBMIT.py View 1 chunk +0 lines, -1 line 0 comments Download
M printing/cups_config_helper.py View 2 chunks +41 lines, -32 lines 0 comments Download
M remoting/tools/gettoken.py View 1 2 chunks +56 lines, -48 lines 0 comments Download
M remoting/tools/register_host.py View 1 2 chunks +77 lines, -69 lines 0 comments Download
M remoting/tools/runclient.py View 1 1 chunk +50 lines, -43 lines 0 comments Download
M remoting/webapp/build-webapp.py View 3 chunks +4 lines, -3 lines 0 comments Download
M remoting/webapp/verify-translations.py View 1 3 chunks +10 lines, -6 lines 0 comments Download
M remoting/webapp/verify-webapp.py View 3 chunks +4 lines, -4 lines 0 comments Download
M testing/generate_gmock_mutant.py View 1 2 chunks +6 lines, -3 lines 0 comments Download
M ui/gfx/gl/generate_bindings.py View 1 8 chunks +10 lines, -3 lines 0 comments Download
M views/PRESUBMIT.py View 1 chunk +1 line, -2 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
M-A Ruel
Context: I'm going to add a presubmit check to enforce some of these rules. Lucky ...
9 years, 1 month ago (2011-11-23 02:55:10 UTC) #1
Jamie
Not sure I fully understand the rationale behind adding the shbang and executable bit to ...
9 years, 1 month ago (2011-11-23 19:33:50 UTC) #2
M-A Ruel
On 2011/11/23 19:33:50, Jamie wrote: > Not sure I fully understand the rationale behind adding ...
9 years, 1 month ago (2011-11-23 19:36:35 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/maruel@chromium.org/8665013/2001
9 years, 1 month ago (2011-11-23 19:45:39 UTC) #4
commit-bot: I haz the power
Can't apply patch for file chrome_frame/tools/test/page_cycler/cf_cycler.py. While running patch -p1 --forward --force; patching file chrome_frame/tools/test/page_cycler/cf_cycler.py ...
9 years, 1 month ago (2011-11-23 19:45:43 UTC) #5
M-A Ruel
On 2011/11/23 19:45:43, I haz the power (commit-bot) wrote: > Can't apply patch for file ...
9 years, 1 month ago (2011-11-23 20:07:27 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/maruel@chromium.org/8665013/7007
9 years, 1 month ago (2011-11-23 20:09:16 UTC) #7
commit-bot: I haz the power
9 years, 1 month ago (2011-11-23 22:22:22 UTC) #8
Change committed as 111427

Powered by Google App Engine
This is Rietveld 408576698