Issue 8665007: Fix process_count tests on chromeos

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 8665007: Fix process_count tests on chromeos (Closed)

Created:
9 years, 1 month ago by Nirnimesh

Modified:
9 years, 1 month ago

Reviewers:
dennis_jeffrey

CC:
chromium-reviews, Nirnimesh, John Grabowski, anantha, dyu1, Paweł Hajdan Jr., dennis_jeffrey

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Fix process_count tests on chromeos GPU process no longer automatically shows up/after at login. R=dennisjeffrey@chromium.org BUG= TEST=

Patch Set 1 #

Patch Set 2 : . #

Total comments: 1

Patch Set 3 : . #

Created: 9 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+17 lines, -5 lines)			Patch
	M	chrome/test/functional/process_count.py	View	1 2	4 chunks	+17 lines, -5 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Nirnimesh

Made a few more modifications, so as not to count Utility processes. PTAL.

9 years, 1 month ago (2011-11-23 00:53:11 UTC) #3

dennis_jeffrey

9 years, 1 month ago (2011-11-23 00:56:10 UTC) #4

LGTM

Just 1 nit to consider before submitting.

http://codereview.chromium.org/8665007/diff/1002/chrome/test/functional/proce...
File chrome/test/functional/process_count.py (right):

http://codereview.chromium.org/8665007/diff/1002/chrome/test/functional/proce...
chrome/test/functional/process_count.py:140: # an extra gpu process
nit: # Flash triggers an extra GPU process on ChromeOS.

Expand Messages | Collapse Messages