Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(16)

Issue 8665006: Build & run unit tests on Aura. (Closed)

Created:
9 years, 1 month ago by Ben Goodger (Google)
Modified:
9 years, 1 month ago
Reviewers:
stevenjb
CC:
chromium-reviews, rdsmith+dwatch_chromium.org, Paweł Hajdan Jr.
Visibility:
Public.

Description

Build & run unit tests on Aura. BUG=none TEST=duh Closed in favor of http://codereview.chromium.org/8677014/

Patch Set 1 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+68 lines, -71 lines) Patch
M build/all.gyp View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/download/download_manager_unittest.cc View 4 chunks +14 lines, -3 lines 0 comments Download
M chrome/browser/printing/print_preview_tab_controller_unittest.cc View 3 chunks +9 lines, -16 lines 0 comments Download
M chrome/browser/ui/select_file_dialog_unittest.cc View 2 chunks +8 lines, -1 line 0 comments Download
M chrome/browser/ui/webui/print_preview_handler_unittest.cc View 6 chunks +19 lines, -34 lines 0 comments Download
M chrome/browser/ui/webui/print_preview_ui_unittest.cc View 3 chunks +6 lines, -14 lines 0 comments Download
M chrome/chrome_tests.gypi View 1 chunk +9 lines, -0 lines 0 comments Download
M chrome/common/service_process_util_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
stevenjb
lgtm
9 years, 1 month ago (2011-11-23 18:22:40 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ben@chromium.org/8665006/2002
9 years, 1 month ago (2011-11-23 18:23:22 UTC) #2
commit-bot: I haz the power
9 years, 1 month ago (2011-11-23 18:23:24 UTC) #3
Can't apply patch for file
chrome/browser/printing/print_preview_tab_controller_unittest.cc.
While running patch -p0 --forward --force;
patching file chrome/browser/printing/print_preview_tab_controller_unittest.cc
Hunk #1 FAILED at 16.
Hunk #2 FAILED at 64.
Hunk #3 FAILED at 131.
3 out of 3 hunks FAILED -- saving rejects to file
chrome/browser/printing/print_preview_tab_controller_unittest.cc.rej

Powered by Google App Engine
This is Rietveld 408576698