chrome/browser/ui/gtk/avatar_menu_button_gtk.cc - Issue 8664028: Profiles: Fixed crash when avatar bubble is launched using ctrl+shift+m with only default profile

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/gtk/avatar_menu_button_gtk.cc

Issue 8664028: Profiles: Fixed crash when avatar bubble is launched using ctrl+shift+m with only default profile (Closed) Base URL: http://git.chromium.org/git/chromium.git@trunk

Patch Set: Fixed review comments Created 9 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/ui/gtk/avatar_menu_button_gtk.cc

diff --git a/chrome/browser/ui/gtk/avatar_menu_button_gtk.cc b/chrome/browser/ui/gtk/avatar_menu_button_gtk.cc

index c96a2ced64cc083e02f219c254003b7f8827fb1f..98b2e18e0bcd30557824074259bf56e6037cc8fe 100644

--- a/chrome/browser/ui/gtk/avatar_menu_button_gtk.cc

+++ b/chrome/browser/ui/gtk/avatar_menu_button_gtk.cc

@@ -49,5 +49,7 @@ gboolean AvatarMenuButtonGtk::OnButtonPressed(GtkWidget* widget,

}

void AvatarMenuButtonGtk::ShowAvatarBubble() {

- new AvatarMenuBubbleGtk(browser_, widget_.get(), arrow_location_, NULL);

+ // Only show the avatar bubble if the avatar button is in the title bar.

+ if (gtk_widget_get_parent_window(widget_.get()))

+ new AvatarMenuBubbleGtk(browser_, widget_.get(), arrow_location_, NULL);

}

« no previous file with comments | « no previous file | no next file » | no next file with comments »