Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7221)

Unified Diff: chrome/browser/ui/gtk/avatar_menu_button_gtk.cc

Issue 8664028: Profiles: Fixed crash when avatar bubble is launched using ctrl+shift+m with only default profile (Closed) Base URL: http://git.chromium.org/git/chromium.git@trunk
Patch Set: Fixed review comments. Used new approach. Created 9 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/gtk/avatar_menu_button_gtk.cc
diff --git a/chrome/browser/ui/gtk/avatar_menu_button_gtk.cc b/chrome/browser/ui/gtk/avatar_menu_button_gtk.cc
index c96a2ced64cc083e02f219c254003b7f8827fb1f..7de210c3c8c47b51023f512105fd22de753ea2f3 100644
--- a/chrome/browser/ui/gtk/avatar_menu_button_gtk.cc
+++ b/chrome/browser/ui/gtk/avatar_menu_button_gtk.cc
@@ -49,5 +49,6 @@ gboolean AvatarMenuButtonGtk::OnButtonPressed(GtkWidget* widget,
}
void AvatarMenuButtonGtk::ShowAvatarBubble() {
- new AvatarMenuBubbleGtk(browser_, widget_.get(), arrow_location_, NULL);
+ if (gtk_widget_get_parent_window(widget_.get()))
James Hawkins 2011/12/01 17:15:55 This isn't the same logic as ShouldDisplayAvatar()
sail 2011/12/01 19:12:23 I think this is ok. ShoudDisplayAvatar decides if
+ new AvatarMenuBubbleGtk(browser_, widget_.get(), arrow_location_, NULL);
}
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698