Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5713)

Unified Diff: chrome/browser/plugin_observer.h

Issue 8664027: Add PluginInstaller to encapsulate information about a missing plug-in. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: review Created 9 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/plugin_installer.cc ('k') | chrome/browser/plugin_observer.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/plugin_observer.h
diff --git a/chrome/browser/plugin_observer.h b/chrome/browser/plugin_observer.h
index a8a27066725e8d61e804af370eb17be3477a02e4..2612e5293137445c84d5fb9c3a789ccc89a0e170 100644
--- a/chrome/browser/plugin_observer.h
+++ b/chrome/browser/plugin_observer.h
@@ -11,6 +11,7 @@
class GURL;
class InfoBarDelegate;
+class PluginInstaller;
class TabContentsWrapper;
class PluginObserver : public TabContentsObserver {
@@ -27,17 +28,14 @@ class PluginObserver : public TabContentsObserver {
void FoundMissingPlugin(int placeholder_id,
const std::string& mime_type,
- const GURL& url,
- const string16& name,
- bool display_url);
+ PluginInstaller* installer);
void DidNotFindMissingPlugin(int placeholder_id,
const std::string& mime_type);
- void InstallMissingPlugin(const GURL& url, bool display_url);
+ void InstallMissingPlugin(PluginInstaller* installer);
base::WeakPtrFactory<PluginObserver> weak_ptr_factory_;
TabContentsWrapper* tab_contents_;
- scoped_ptr<InfoBarDelegate> plugin_installer_; // Lazily created.
DISALLOW_COPY_AND_ASSIGN(PluginObserver);
};
« no previous file with comments | « chrome/browser/plugin_installer.cc ('k') | chrome/browser/plugin_observer.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698