Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7330)

Unified Diff: chrome/browser/plugin_finder.h

Issue 8664027: Add PluginInstaller to encapsulate information about a missing plug-in. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: review Created 9 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/plugin_finder.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/plugin_finder.h
diff --git a/chrome/browser/plugin_finder.h b/chrome/browser/plugin_finder.h
index e9b18d086af2b232e3e5c42f26b5c98d5e66c96c..3359edb4d9c5b641c95b650156760fe72d3f7ea4 100644
--- a/chrome/browser/plugin_finder.h
+++ b/chrome/browser/plugin_finder.h
@@ -6,8 +6,8 @@
#define CHROME_BROWSER_PLUGIN_FINDER_H_
#pragma once
+#include <map>
#include <string>
-#include <vector>
#include "base/callback.h"
#include "base/memory/scoped_ptr.h"
@@ -19,16 +19,11 @@ class ListValue;
}
class GURL;
+class PluginInstaller;
class PluginFinder {
public:
- // If |display_url| is false, |plugin_url| is the URL of the download page for
- // the plug-in, which should be opened in a new tab. If it is true,
- // |plugin_url| is the URL of the plug-in installer binary, which can be
- // directly downloaded.
- typedef base::Callback<void(GURL /* plugin_url */,
- string16 /* name */,
- bool /* display_url */)> FindPluginCallback;
+ typedef base::Callback<void(PluginInstaller*)> FindPluginCallback;
static PluginFinder* GetInstance();
@@ -47,6 +42,7 @@ class PluginFinder {
~PluginFinder();
scoped_ptr<base::ListValue> plugin_list_;
+ std::map<std::string, PluginInstaller*> installers_;
DISALLOW_COPY_AND_ASSIGN(PluginFinder);
};
« no previous file with comments | « no previous file | chrome/browser/plugin_finder.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698