Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(848)

Issue 8664026: Add browser tests that check if the IME hot keys like Shift+Alt are working correctly (Closed)

Created:
9 years ago by Yusuke Sato
Modified:
9 years ago
Reviewers:
Zachary Kuznia
CC:
chromium-reviews, sadrul, nkostylev+watch_chromium.org, derat+watch_chromium.org, Paweł Hajdan Jr., stevenjb+watch_chromium.org, davemoore+watch_chromium.org, yusukes+watch_chromium.org
Visibility:
Public.

Description

Add browser tests that check if the IME hot keys like Shift+Alt are working correctly. The test should prevent a regression like crosbug.com/23067 in the future. BUG=chromium-os:23067 TEST=ran the browser test Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=112168

Patch Set 1 #

Patch Set 2 : review #

Patch Set 3 : rebase, review #

Unified diffs Side-by-side diffs Delta from patch set Stats (+164 lines, -22 lines) Patch
M chrome/browser/chromeos/system_key_event_listener_browsertest.cc View 1 2 9 chunks +164 lines, -22 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
Yusuke Sato
Zach, can I ask you to review this?
9 years ago (2011-11-30 04:35:22 UTC) #1
Zachary Kuznia
lgtm
9 years ago (2011-11-30 04:53:03 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/yusukes@chromium.org/8664026/4001
9 years ago (2011-11-30 06:43:42 UTC) #3
commit-bot: I haz the power
Try job failure for 8664026-4001 (retry) on mac_rel for step "compile" (clobber build). It's a ...
9 years ago (2011-11-30 07:24:18 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/yusukes@chromium.org/8664026/4001
9 years ago (2011-11-30 07:27:09 UTC) #5
commit-bot: I haz the power
9 years ago (2011-11-30 08:44:47 UTC) #6
Change committed as 112168

Powered by Google App Engine
This is Rietveld 408576698