Update Panel UI looks on Windows.

Update Panel UI looks on Windows.

The following changes are made:
1) Use custom colors when default theme is used.
2) Title font is changed to bold.
3) Remove client area edges.
4) Spacing between controls are tuned.

BUG=104635
TEST=existing tests plus manually verifying the panel titlebar UI looks on Windows

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=112161

[Dmitry Titov, 2011-11-29 04:04:02]

http://codereview.chromium.org/8664021/diff/1/chrome/browser/ui/panels/panel_...
File chrome/browser/ui/panels/panel_browser_frame_view.cc (right):

http://codereview.chromium.org/8664021/diff/1/chrome/browser/ui/panels/panel_...
chrome/browser/ui/panels/panel_browser_frame_view.cc:140: SkPaint
active_background_default_paint;
I wonder if this is a good thing to have objects with complex destructors as
static. They tend to have unpredictable timing of destruction during process
shutdown. 
It would be better to use CR_DEFINE_STATIC_LOCAL (see for example,
browser_list.cc)

http://codereview.chromium.org/8664021/diff/1/chrome/browser/ui/panels/panel_...
chrome/browser/ui/panels/panel_browser_frame_view.cc:144: void
InitializeGradientPaint(SkPaint* paint,
why not return the SkPaint*, especially if statics are not
statically-initialized?

[jianli, 2011-11-29 19:30:15]

http://codereview.chromium.org/8664021/diff/1/chrome/browser/ui/panels/panel_...
File chrome/browser/ui/panels/panel_browser_frame_view.cc (right):

http://codereview.chromium.org/8664021/diff/1/chrome/browser/ui/panels/panel_...
chrome/browser/ui/panels/panel_browser_frame_view.cc:140: SkPaint
active_background_default_paint;
On 2011/11/29 04:04:03, Dmitry Titov wrote:
> I wonder if this is a good thing to have objects with complex destructors as
> static. They tend to have unpredictable timing of destruction during process
> shutdown. 
> It would be better to use CR_DEFINE_STATIC_LOCAL (see for example,
> browser_list.cc)

Done.

http://codereview.chromium.org/8664021/diff/1/chrome/browser/ui/panels/panel_...
chrome/browser/ui/panels/panel_browser_frame_view.cc:144: void
InitializeGradientPaint(SkPaint* paint,
On 2011/11/29 04:04:03, Dmitry Titov wrote:
> why not return the SkPaint*, especially if statics are not
> statically-initialized?

I still need this to do the delay initialization when I change to use
CR_DEFINE_STATIC_LOCAL.

[Dmitry Titov, 2011-11-29 21:56:22]

As discussed offline, we want to get rid of static_cast..
Also, I've added a refernce to the bug 104635 so it gets details ofd this patch
reflected.

[jianli, 2011-11-30 01:27:56]

Please review again. Thanks.

[Dmitry Titov, 2011-11-30 01:43:56]

LGTM

[commit-bot: I haz the power, 2011-11-30 05:43:31]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/jianli@chromium.org/8664021/7001

[commit-bot: I haz the power, 2011-11-30 08:18:10]

Change committed as 112161