Issue 8662051: retry r112077 - recently closed menu: respect middle click

Issue 8662051: retry r112077 - recently closed menu: respect middle click (Closed)

Created:
9 years ago by Evan Stade

Modified:
9 years ago

Reviewers:
Elliot Glaysher, sky

CC:
chromium-reviews, jam, dpranke-watch+content_chromium.org, joi+watch-content_chromium.org, arv (Not doing code reviews), darin-cc_chromium.org, Paweł Hajdan Jr., estade+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

retry r112077 - recently closed menu: respect middle click (and other disposition modifiers) BUG=7678 TEST=trybots Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=113059

Patch Set 1 #

Created: 9 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+100 lines, -74 lines)			Patch
M	chrome/browser/resources/ntp4/apps_page.js	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	chrome/browser/resources/ntp4/recently_closed.js	View	1 chunk	+5 lines, -5 lines	0 comments	Download
M	chrome/browser/sessions/session_restore_browsertest.cc	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	chrome/browser/sessions/tab_restore_service.h	View	3 chunks	+11 lines, -9 lines	0 comments	Download
M	chrome/browser/sessions/tab_restore_service.cc	View	7 chunks	+24 lines, -18 lines	0 comments	Download
M	chrome/browser/ui/browser.cc	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	chrome/browser/ui/cocoa/history_menu_cocoa_controller.mm	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/ui/gtk/global_history_menu.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/ui/webui/ntp/app_launcher_handler.cc	View	5 chunks	+5 lines, -24 lines	0 comments	Download
M	chrome/browser/ui/webui/ntp/recently_closed_tabs_handler.cc	View	2 chunks	+13 lines, -12 lines	0 comments	Download
M	chrome/browser/ui/webui/web_ui_util.h	View	2 chunks	+9 lines, -0 lines	0 comments	Download
M	chrome/browser/ui/webui/web_ui_util.cc	View	2 chunks	+20 lines, -0 lines	0 comments	Download
M	content/browser/disposition_utils.h	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	content/browser/webui/web_ui.cc	View	1 chunk	+5 lines, -0 lines	0 comments	Download

Messages

Total messages: 7 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/estade@chromium.org/8662051/1

9 years ago (2011-11-30 22:48:01 UTC) #3

commit-bot: I haz the power

Presubmit check for 8662051-1 failed and returned exit status 1. Running presubmit commit checks ...

9 years ago (2011-11-30 22:48:08 UTC) #4

Evan Stade

+sky for owners review this is the same patch as before, with a compile fix

9 years ago (2011-12-01 01:52:01 UTC) #5

Sorry I missed this. LGTM

Expand Messages | Collapse Messages