Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(274)

Unified Diff: base/cancelable_callback_unittest.cc

Issue 8662047: base::Bind: Implement a 1-arity CancelableCallback and use this to implement (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Review fixes. Created 9 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: base/cancelable_callback_unittest.cc
diff --git a/base/cancelable_callback_unittest.cc b/base/cancelable_callback_unittest.cc
index 980359b963cb42fe81e0611bc2007b57419b0641..ddaf6a35b43bd7c4d303eabdfd4004e1d17479f1 100644
--- a/base/cancelable_callback_unittest.cc
+++ b/base/cancelable_callback_unittest.cc
@@ -28,7 +28,7 @@ void RefCountedParam(const scoped_refptr<TestRefCounted>& ref_counted) {}
// - After Cancel(), Run() completes but has no effect.
TEST(CancelableCallbackTest, Cancel) {
int count = 0;
- CancelableCallback cancelable(
+ CancelableClosure cancelable(
base::Bind(&Increment, base::Unretained(&count)));
base::Closure callback = cancelable.callback();
@@ -47,7 +47,7 @@ TEST(CancelableCallbackTest, Cancel) {
// - Cancel() cancels all copies of the wrapped callback.
TEST(CancelableCallbackTest, MultipleCancel) {
int count = 0;
- CancelableCallback cancelable(
+ CancelableClosure cancelable(
base::Bind(&Increment, base::Unretained(&count)));
base::Closure callback1 = cancelable.callback();
@@ -74,7 +74,7 @@ TEST(CancelableCallbackTest, CallbackCanceledOnDestruction) {
base::Closure callback;
{
- CancelableCallback cancelable(
+ CancelableClosure cancelable(
base::Bind(&Increment, base::Unretained(&count)));
callback = cancelable.callback();
@@ -92,7 +92,7 @@ TEST(CancelableCallbackTest, CancelDropsCallback) {
scoped_refptr<TestRefCounted> ref_counted = new TestRefCounted;
EXPECT_TRUE(ref_counted->HasOneRef());
- CancelableCallback cancelable(base::Bind(RefCountedParam, ref_counted));
+ CancelableClosure cancelable(base::Bind(RefCountedParam, ref_counted));
EXPECT_FALSE(cancelable.IsCancelled());
EXPECT_TRUE(ref_counted.get());
EXPECT_FALSE(ref_counted->HasOneRef());
@@ -109,7 +109,7 @@ TEST(CancelableCallbackTest, CancelDropsCallback) {
// - Reset() deactivates outstanding callbacks.
TEST(CancelableCallbackTest, Reset) {
int count = 0;
- CancelableCallback cancelable(
+ CancelableClosure cancelable(
base::Bind(&Increment, base::Unretained(&count)));
base::Closure callback = cancelable.callback();
@@ -140,7 +140,7 @@ TEST(CancelableCallbackTest, Reset) {
// IsCanceled().
// - Cancel() transforms the CancelableCallback into a cancelled state.
TEST(CancelableCallbackTest, IsNull) {
- CancelableCallback cancelable;
+ CancelableClosure cancelable;
EXPECT_TRUE(cancelable.IsCancelled());
int count = 0;
@@ -158,7 +158,7 @@ TEST(CancelableCallbackTest, PostTask) {
MessageLoop loop(MessageLoop::TYPE_DEFAULT);
int count = 0;
- CancelableCallback cancelable(base::Bind(&Increment,
+ CancelableClosure cancelable(base::Bind(&Increment,
base::Unretained(&count)));
MessageLoop::current()->PostTask(FROM_HERE, cancelable.callback());

Powered by Google App Engine
This is Rietveld 408576698