Refactor some of the duplicated code in the tests using a socket server

tests/standalone/src/EchoServerTest.dart

 // Copyright (c) 2011, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 //
 // Echo server test program for testing sockets.
 //
 // VMOptions=
 // VMOptions=--short_socket_read
 // VMOptions=--short_socket_write
 // VMOptions=--short_socket_read --short_socket_write
 
-#library("EchoServerTest.dart");
+#source("TestingServer.dart");
 
 class EchoServerTest {
 
   static void testMain() {
     EchoServerGame echoServerGame = new EchoServerGame.start();
   }
 }
 
 class EchoServerGame {
 
   static final MSGSIZE = 10;
-  static final SERVERINIT = 0;
-  static final SERVERSHUTDOWN = -1;
   static final MESSAGES = 100;
   static final FIRSTCHAR = 65;
 
   EchoServerGame.start()
       : _receivePort = new ReceivePort(),
         _sendPort = null,
         _buffer = new List<int>(MSGSIZE),
         _messages = 0 {
     for (int i = 0; i < MSGSIZE; i++) {
       _buffer[i] = FIRSTCHAR + i;
@@ skipping 57 matching lines @@
         }
 
         handleWrite();
       }
 
       _socket.dataHandler = messageHandler;
       _socket.errorHandler = errorHandler;
       writeMessage();
     }
 
-    _socket = new Socket(EchoServer.HOST, _port);
+    _socket = new Socket(TestingServer.HOST, _port);
     if (_socket !== null) {
       _socket.connectHandler = connectHandler;
     } else {
       Expect.fail("Socket creation failed");
     }
   }
 
   void start() {
     _receivePort.receive((var message, SendPort replyTo) {
       _port = message;
       sendData();
     });
-    _sendPort.send(SERVERINIT, _receivePort.toSendPort());
+    _sendPort.send(TestingServer.INIT, _receivePort.toSendPort());
   }
 
   void shutdown() {
-    _sendPort.send(SERVERSHUTDOWN, _receivePort.toSendPort());
+    _sendPort.send(TestingServer.SHUTDOWN, _receivePort.toSendPort());
     _receivePort.close();
   }
 
   int _port;
   ReceivePort _receivePort;
   SendPort _sendPort;
   List<int> _buffer;
   int _messages;
 }
 
-class EchoServer extends Isolate {
+class EchoServer extends TestingServer {
 
-  static final HOST = "127.0.0.1";
   static final msgSize = EchoServerGame.MSGSIZE;
 
+  void connectionHandler() {
+    Socket _client;
 
-  void main() {
+    void messageHandler() {
 
-    void connectionHandler() {
-      Socket _client;
+      List<int> buffer = new List<int>(msgSize);
+      int bytesRead = 0;
 
-      void messageHandler() {
+      void handleRead() {
+        int read = _client.readList(buffer, bytesRead, msgSize - bytesRead);
+        if (read > 0) {
+          bytesRead += read;
+          if (bytesRead < msgSize) {
+            // We check every time the whole buffer to verify data integrity.
+            for (int i = 0; i < bytesRead; i++) {
+              Expect.equals(EchoServerGame.FIRSTCHAR + i, buffer[i]);
+            }
+            _client.dataHandler = handleRead;
+          } else {
+            // We check every time the whole buffer to verify data integrity.
+            for (int i = 0; i < msgSize; i++) {
+              Expect.equals(EchoServerGame.FIRSTCHAR + i, buffer[i]);
+            }
 
-        List<int> buffer = new List<int>(msgSize);
-        int bytesRead = 0;
+            void writeMessage() {
 
-        void handleRead() {
-          int read = _client.readList(buffer, bytesRead, msgSize - bytesRead);
-          if (read > 0) {
-            bytesRead += read;
-            if (bytesRead < msgSize) {
-              // We check every time the whole buffer to verify data integrity.
-              for (int i = 0; i < bytesRead; i++) {
-                Expect.equals(EchoServerGame.FIRSTCHAR + i, buffer[i]);
+              int bytesWritten = 0;
+
+              void handleWrite() {
+                int written = _client.writeList(
+                    buffer, bytesWritten, msgSize - bytesWritten);
+                bytesWritten += written;
+                if (bytesWritten < msgSize) {
+                  _client.writeHandler = handleWrite;
+                } else {
+                  _client.close(true);
+                }
               }
-              _client.dataHandler = handleRead;
-            } else {
-              // We check every time the whole buffer to verify data integrity.
-              for (int i = 0; i < msgSize; i++) {
-                Expect.equals(EchoServerGame.FIRSTCHAR + i, buffer[i]);
-              }
-
-              void writeMessage() {
-
-                int bytesWritten = 0;
-
-                void handleWrite() {
-                  int written = _client.writeList(
-                        buffer, bytesWritten, msgSize - bytesWritten);
-                  bytesWritten += written;
-                  if (bytesWritten < msgSize) {
-                    _client.writeHandler = handleWrite;
-                  } else {
-                    _client.close(true);
-                  }
-                }
-                handleWrite();
-              }
-              writeMessage();
+              handleWrite();
             }
+            writeMessage();
           }
         }
-
-        handleRead();
       }
 
-      void closeHandler() {
-        _client.close();
-      }
-
-      void errorHandler() {
-        Expect.fail("Socket error");
-      }
-
-      _client = _server.accept();
-      _client.dataHandler = messageHandler;
-      _client.closeHandler = closeHandler;
-      _client.errorHandler = errorHandler;
+      handleRead();
     }
 
-    void errorHandlerServer() {
-      Expect.fail("Server socket error");
+    void closeHandler() {
+      _client.close();
     }
 
-    this.port.receive((message, SendPort replyTo) {
-      if (message == EchoServerGame.SERVERINIT) {
-        _server = new ServerSocket(HOST, 0, 10);
-        Expect.equals(true, _server !== null);
-        _server.connectionHandler = connectionHandler;
-        _server.errorHandler = errorHandlerServer;
-        replyTo.send(_server.port, null);
-      } else if (message == EchoServerGame.SERVERSHUTDOWN) {
-        _server.close();
-        this.port.close();
-      }
-    });
+    void errorHandler() {
+      Expect.fail("Socket error");
+    }
+
+    _client = _server.accept();
+    _client.dataHandler = messageHandler;
+    _client.closeHandler = closeHandler;
+    _client.errorHandler = errorHandler;
   }
-
-  ServerSocket _server;
 }
 
 main() {
   EchoServerTest.testMain();
 }