Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(40)

Issue 8662035: Revert 111378 - HQP Refactoring (in Preparation for SQLite Cache) (Closed)

Created:
9 years ago by Zhenyao Mo
Modified:
9 years ago
Reviewers:
mrossetti
CC:
chromium-reviews, brettw-cc_chromium.org, James Su, Paweł Hajdan Jr.
Visibility:
Public.

Description

Revert 111378 - HQP Refactoring (in Preparation for SQLite Cache) (See crbug.com/105340 for reverting reason and how to reproduce the issue locally) 1. Move ownership of the InMemoryURLIndex from the InMemoryHistoryBackend to the HistoryService, where it truly belongs. 2. Handle (by notification) URL visits, updates and deletes. Refactor use of NOTIFICATION_HISTORY_URLS_DELETED to provide the deleted URLRow so that row ID is available. 3. Correctly handle the adding and removing of page title words when a URL change is detected. 4. Other small cleanups. BUG=96731, 92718 TEST=Unit tests updated. TBR=atwilson (for profile_sync_service_typed_url_unittest.cc) Previously reviewed as: http://codereview.chromium.org/8384024/ Review URL: http://codereview.chromium.org/8451009 TBR=mrossetti@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=111482

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+212 lines, -301 lines) Patch
M chrome/browser/autocomplete/history_provider.h View 1 chunk +0 lines, -4 lines 0 comments Download
M chrome/browser/autocomplete/history_provider.cc View 1 chunk +1 line, -3 lines 0 comments Download
M chrome/browser/autocomplete/history_quick_provider.cc View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/autocomplete/history_quick_provider_unittest.cc View 2 chunks +6 lines, -4 lines 0 comments Download
M chrome/browser/history/expire_history_backend.cc View 1 chunk +1 line, -3 lines 0 comments Download
M chrome/browser/history/history.h View 3 chunks +2 lines, -10 lines 0 comments Download
M chrome/browser/history/history.cc View 6 chunks +7 lines, -21 lines 0 comments Download
M chrome/browser/history/history_backend.h View 1 chunk +0 lines, -3 lines 0 comments Download
M chrome/browser/history/history_backend.cc View 3 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/history/history_backend_unittest.cc View 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/history/history_notifications.h View 5 chunks +5 lines, -10 lines 0 comments Download
M chrome/browser/history/history_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/history/in_memory_history_backend.h View 2 chunks +6 lines, -0 lines 0 comments Download
M chrome/browser/history/in_memory_history_backend.cc View 2 chunks +32 lines, -9 lines 0 comments Download
M chrome/browser/history/in_memory_url_index.h View 8 chunks +19 lines, -43 lines 0 comments Download
M chrome/browser/history/in_memory_url_index.cc View 7 chunks +55 lines, -106 lines 0 comments Download
M chrome/browser/history/in_memory_url_index_unittest.cc View 16 chunks +72 lines, -80 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Zhenyao Mo
9 years ago (2011-11-24 02:33:13 UTC) #1
mrossetti
9 years ago (2011-11-28 17:30:07 UTC) #2
lgtm

Powered by Google App Engine
This is Rietveld 408576698