Issue 8662031: base::Bind: Convert (again) chrome/browser/printing.

Issue 8662031: base::Bind: Convert (again) chrome/browser/printing. (Closed)

Created:
9 years ago by James Hawkins

Modified:
9 years ago

Reviewers:
Lei Zhang, csilv

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

base::Bind: Convert (again) chrome/browser/printing. BUG=none TEST=none R=csilv@chromium.org,thestig@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=111490

Patch Set 4 : Revert last upload. #

Created: 9 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+47 lines, -81 lines)			Patch
M	chrome/browser/printing/print_job_worker.h	View		1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/printing/print_job_worker.cc	View		6 chunks	+32 lines, -59 lines	0 comments	Download
M	chrome/browser/printing/printer_manager_dialog_win.cc	View	1	2 chunks	+14 lines, -21 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Lei Zhang

http://codereview.chromium.org/8662031/diff/1/chrome/browser/printing/printer_manager_dialog_win.cc File chrome/browser/printing/printer_manager_dialog_win.cc (right): http://codereview.chromium.org/8662031/diff/1/chrome/browser/printing/printer_manager_dialog_win.cc#newcode32 chrome/browser/printing/printer_manager_dialog_win.cc:32: FROM_HERE, base::Bind(OpenPrintersDialogTask)); Do you need to #include "base/bind.h" here?

9 years ago (2011-11-23 23:34:03 UTC) #2

James Hawkins

9 years ago (2011-11-24 00:35:11 UTC) #3

LGTM

Expand Messages | Collapse Messages