Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(162)

Issue 8662026: roll gyp 1096:1098 (Closed)

Created:
9 years, 1 month ago by Nico
Modified:
9 years, 1 month ago
Reviewers:
M-A Ruel
CC:
chromium-reviews
Visibility:
Public.

Description

roll gyp 1096:1098 1097: Make dump_dependency_json work on Mac and possibly other OSs. 1098: make: Remove a few unused imports. BUG=103273 TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=111466

Patch Set 1 #

Patch Set 2 : 1098 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M DEPS View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 10 (0 generated)
Nico
Here you go :-) Please check cq if it lgty
9 years, 1 month ago (2011-11-23 20:39:01 UTC) #1
M-A Ruel
galvanized rubberstamp lgtm
9 years, 1 month ago (2011-11-23 20:39:56 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/thakis@chromium.org/8662026/1
9 years, 1 month ago (2011-11-23 20:46:10 UTC) #3
commit-bot: I haz the power
Try job failure for 8662026-1 (previous was lost) (retry) on mac_rel for step "compile" (clobber ...
9 years, 1 month ago (2011-11-23 21:56:11 UTC) #4
M-A Ruel
On 2011/11/23 21:56:11, I haz the power (commit-bot) wrote: > Try job failure for 8662026-1 ...
9 years, 1 month ago (2011-11-23 21:57:48 UTC) #5
Nico
> Looks like a genuine regression in protobuf generation. Yeah :-( I'll change this to ...
9 years, 1 month ago (2011-11-23 22:30:29 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/thakis@chromium.org/8662026/1002
9 years, 1 month ago (2011-11-23 22:32:58 UTC) #7
commit-bot: I haz the power
Try job failure for 8662026-1002 (previous was lost) (retry) on mac_rel for step "compile" (clobber ...
9 years, 1 month ago (2011-11-23 23:40:14 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/thakis@chromium.org/8662026/1002
9 years, 1 month ago (2011-11-23 23:48:47 UTC) #9
commit-bot: I haz the power
9 years, 1 month ago (2011-11-24 01:06:56 UTC) #10
Change committed as 111466

Powered by Google App Engine
This is Rietveld 408576698