Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(772)

Issue 8662025: Fix python scripts src/chrome_frame/tools/test/page_cycler/cf_cycler.py (Closed)

Created:
9 years, 1 month ago by M-A Ruel
Modified:
9 years, 1 month ago
Reviewers:
robertshield
CC:
chromium-reviews, amit, pam+watch_chromium.org
Visibility:
Public.

Description

Fix python scripts src/chrome_frame/tools/test/page_cycler/cf_cycler.py Make sure that: - shebang is only present for executable files - __main__ is only present for executable files - file's executable bit is coherent Also fix EOF LF to be only one. * Doing it separately since the CQ cannot process it. TBR=robertshield@chromium.org BUG=105108 TEST= Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=111399

Patch Set 1 #

Patch Set 2 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+100 lines, -99 lines) Patch
M chrome_frame/tools/test/page_cycler/cf_cycler.py View 1 1 chunk +100 lines, -99 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
M-A Ruel
Extracted from http://codereview.chromium.org/8665013/. It needs to be committed manually since it is CRLF.
9 years, 1 month ago (2011-11-23 20:08:27 UTC) #1
robertshield
9 years, 1 month ago (2011-11-23 20:12:26 UTC) #2
On 2011/11/23 20:08:27, Marc-Antoine Ruel wrote:
> Extracted from http://codereview.chromium.org/8665013/. It needs to be
committed
> manually since it is CRLF.

LGTM

Powered by Google App Engine
This is Rietveld 408576698