Issue 8662023: Add OVERRIDE to remoting/.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 8662023: Add OVERRIDE to remoting/. (Closed)

Created:
9 years, 1 month ago by Avi (use Gerrit)

Modified:
9 years, 1 month ago

Reviewers:
awong, Wez

CC:
chromium-reviews, jamiewalch+watch_chromium.org, hclam+watch_chromium.org, simonmorris+watch_chromium.org, wez+watch_chromium.org, garykac+watch_chromium.org, lambroslambrou+watch_chromium.org, sergeyu+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Add OVERRIDE to remoting/. BUG=104314 TEST=no change Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=111414

Patch Set 1 #

Created: 9 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -1 line)			Patch
	M	remoting/host/local_input_monitor_thread_linux.h	View		2 chunks	+2 lines, -1 line	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

awong

9 years, 1 month ago (2011-11-23 19:32:46 UTC) #3

LGTM

On Wed, Nov 23, 2011 at 11:26 AM, <avi@chromium.org> wrote:

> Reviewers: awong,
>
> Description:
> Add OVERRIDE to remoting/.
>
> BUG=104314
> TEST=no change
>
>
> Please review this at
http://codereview.chromium.**org/8662023/<http://codereview.chromium.org/8662...
>
> SVN Base:
svn://svn.chromium.org/chrome/**trunk/src<http://svn.chromium.org/chrome/trunk/src>
>
> Affected files:
>  M remoting/host/local_input_**monitor_thread_linux.h
>
>
> Index: remoting/host/local_input_**monitor_thread_linux.h
> diff --git a/remoting/host/local_input_**monitor_thread_linux.h
> b/remoting/host/local_input_**monitor_thread_linux.h
> index 567882c8683edc934c7995a3549973**fa8cdf8106..**
> d30e7c4b8992cf65beaa1fdb2a328b**2dbfe1a88f 100644
> --- a/remoting/host/local_input_**monitor_thread_linux.h
> +++ b/remoting/host/local_input_**monitor_thread_linux.h
> @@ -5,6 +5,7 @@
>  #ifndef LOCAL_INPUT_MONITOR_THREAD_**LINUX_H_
>  #define LOCAL_INPUT_MONITOR_THREAD_**LINUX_H_
>
> +#include "base/compiler_specific.h"
>  #include "base/threading/simple_thread.**h"
>  #include "third_party/skia/include/**core/SkPoint.h"
>
> @@ -20,7 +21,7 @@ class LocalInputMonitorThread : public
> base::SimpleThread {
>   virtual ~LocalInputMonitorThread();
>
>   void Stop();
> -  virtual void Run();
> +  virtual void Run() OVERRIDE;
>
>   void LocalMouseMoved(const SkIPoint& pos);
>   void LocalKeyPressed(int key_code, bool down);
>
>
>

Expand Messages | Collapse Messages