Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(401)

Issue 8662014: Pepper: Fix the definition of |PPB_AudioInput_Callback|. (Closed)

Created:
9 years, 1 month ago by viettrungluu
Modified:
9 years, 1 month ago
CC:
chromium-reviews, piman+watch_chromium.org, darin-cc_chromium.org, yzshen+watch_chromium.org, ihf+watch_chromium.org, seriesrover
Visibility:
Public.

Description

Pepper: Fix the definition of |PPB_AudioInput_Callback|. The |sample_buffer| parameter is an "in" parameter, not "out". (And consequently should be |const void*|, not |void*|.) TBR=dmichael@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=111379

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -6 lines) Patch
M ppapi/api/dev/ppb_audio_input_dev.idl View 1 chunk +2 lines, -2 lines 0 comments Download
M ppapi/c/dev/ppb_audio_input_dev.h View 2 chunks +3 lines, -3 lines 0 comments Download
M ppapi/proxy/resource_creation_proxy.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
viettrungluu
9 years, 1 month ago (2011-11-23 17:32:05 UTC) #1
viettrungluu
yzshen -> review, dmichael (TBR probably) -> OWNERS
9 years, 1 month ago (2011-11-23 18:50:18 UTC) #2
yzshen1
lgtm
9 years, 1 month ago (2011-11-23 18:51:09 UTC) #3
dmichael (off chromium)
9 years, 1 month ago (2011-11-23 18:52:20 UTC) #4
lgtm

Powered by Google App Engine
This is Rietveld 408576698