Rename chrome.experimental.webRequest to chrome.webRequest and chrome.webRequestBlocking

Rename chrome.experimental.webRequest to chrome.webRequest

Note that this CL also introduces a new permission webRequestBlocking that is required in addition to webRequest if you want to use blocking request handlers.


BUG=60101
TEST=no

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=112181

[battre, 2011-11-23 16:04:40]

Please review. Thanks.

[Matt Perry, 2011-11-28 20:38:11]

LGTM with below change.

Have you tested that upgrading an extension that adds the "webRequest" or
"webRequestBlocking" permission does not prompt the user? I think that normally
only happens on autoupdate, so you might have to hack the code to simulate an
autoupdate when you're doing a manual install.

http://codereview.chromium.org/8662010/diff/6001/chrome/common/extensions/ext...
File chrome/common/extensions/extension_permission_set.cc (right):

http://codereview.chromium.org/8662010/diff/6001/chrome/common/extensions/ext...
chrome/common/extensions/extension_permission_set.cc:322:
ExtensionAPIPermission::kWebRequestBlocking, "webRequest_blocking", 0,
Make it webRequestBlocking.

[battre, 2011-11-29 09:59:47]

I have tested that the permission update does not trigger a warning. I have
installed a simple extension with "<all_urls>" permission and an update_url
(http://code.google.com/chrome/extensions/autoupdate.html). The update file
pointed to an extension that added "webRequest" and "webRequestBlocking". I was
not asked to confirm the extended permissions.

http://codereview.chromium.org/8662010/diff/6001/chrome/common/extensions/ext...
File chrome/common/extensions/extension_permission_set.cc (right):

http://codereview.chromium.org/8662010/diff/6001/chrome/common/extensions/ext...
chrome/common/extensions/extension_permission_set.cc:322:
ExtensionAPIPermission::kWebRequestBlocking, "webRequest_blocking", 0,
On 2011/11/28 20:38:12, Matt Perry wrote:
> Make it webRequestBlocking.

Done.

[Matt Perry, 2011-11-29 18:30:11]

Perfect, thanks! And lgtm again

On 2011/11/29 09:59:47, battre wrote:
> I have tested that the permission update does not trigger a warning. I have
> installed a simple extension with "<all_urls>" permission and an update_url
> (http://code.google.com/chrome/extensions/autoupdate.html). The update file
> pointed to an extension that added "webRequest" and "webRequestBlocking". I
was
> not asked to confirm the extended permissions.
> 
>
http://codereview.chromium.org/8662010/diff/6001/chrome/common/extensions/ext...
> File chrome/common/extensions/extension_permission_set.cc (right):
> 
>
http://codereview.chromium.org/8662010/diff/6001/chrome/common/extensions/ext...
> chrome/common/extensions/extension_permission_set.cc:322:
> ExtensionAPIPermission::kWebRequestBlocking, "webRequest_blocking", 0,
> On 2011/11/28 20:38:12, Matt Perry wrote:
> > Make it webRequestBlocking.
> 
> Done.

[commit-bot: I haz the power, 2011-11-29 20:57:19]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/battre@chromium.org/8662010/13030

[commit-bot: I haz the power, 2011-11-29 20:57:30]

Presubmit check for 8662010-13030 failed and returned exit status 1.

Running presubmit commit checks ...

** Presubmit Warnings **
This change modifies the extension docs but the generated docs have not been
updated properly. See chrome/common/extensions/docs/README.txt for more info.
(Report problems to tessamac@chromium.org.)
 - Changes to chrome/common/extensions/docs/static/webRequest.html not reflected
in generated doc.
First build DumpRenderTree, then update the docs by running:
  chrome/common/extensions/docs/build/build.py

Presubmit checks took 2.6s to calculate.