Issue 8662009: Porting r10023 and r10054 to x64 (pointer cache for external strings).

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 8662009: Porting r10023 and r10054 to x64 (pointer cache for external strings). (Closed)

Created:
9 years, 1 month ago by Yang

Modified:
9 years, 1 month ago

Reviewers:
Lasse Reichstein

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Porting r10023 and r10054 to x64 (pointer cache for external strings). Committed: http://code.google.com/p/v8/source/detail?r=10058

Patch Set 1 #

Total comments: 3

Created: 9 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+144 lines, -154 lines)			Patch
M	src/codegen.h	View	1 chunk	+0 lines, -17 lines	0 comments	Download
M	src/ia32/codegen-ia32.h	View	1 chunk	+16 lines, -0 lines	0 comments	Download
M	src/x64/code-stubs-x64.cc	View	2 chunks	+4 lines, -62 lines	0 comments	Download
M	src/x64/codegen-x64.h	View	1 chunk	+15 lines, -0 lines	0 comments	Download
M	src/x64/codegen-x64.cc	View	1 chunk	+104 lines, -0 lines	3 comments	Download
M	src/x64/lithium-codegen-x64.cc	View	1 chunk	+5 lines, -75 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Yang

Please take a look. This CL replaces http://codereview.chromium.org/8569008/ http://codereview.chromium.org/8662009/diff/1/src/x64/codegen-x64.cc File src/x64/codegen-x64.cc (right): http://codereview.chromium.org/8662009/diff/1/src/x64/codegen-x64.cc#newcode397 src/x64/codegen-x64.cc:397: // ...

9 years, 1 month ago (2011-11-23 14:04:07 UTC) #1

Lasse Reichstein

9 years, 1 month ago (2011-11-24 09:52:55 UTC) #2

LGTM

http://codereview.chromium.org/8662009/diff/1/src/x64/codegen-x64.cc
File src/x64/codegen-x64.cc (right):

http://codereview.chromium.org/8662009/diff/1/src/x64/codegen-x64.cc#newcode408
src/x64/codegen-x64.cc:408: __ testb(result,
Immediate(kShortExternalStringTag));
kShortExternalStringMask

http://codereview.chromium.org/8662009/diff/1/src/x64/codegen-x64.cc#newcode438
src/x64/codegen-x64.cc:438: // Check whether the string is sequential. The only
non-sequential
Slightly confusing comment. How about something like:
"Distinguish sequential and external strings. Only these two string
representations can reach here (slices and flat cons strings have been reduced
to the underlying sequential or external string)."

Expand Messages | Collapse Messages