Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(9644)

Unified Diff: chrome/common/extensions/extension_permission_set_unittest.cc

Issue 8662008: Implement chrome.systemPrivate.getIncognitoModeAvailability extension API function (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Made destructor virtual Created 9 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/common/extensions/extension_permission_set_unittest.cc
diff --git a/chrome/common/extensions/extension_permission_set_unittest.cc b/chrome/common/extensions/extension_permission_set_unittest.cc
index 4e4577d33e7692b7f6ad836b1a3e158684764892..9ff1b20982e70eaa5e34b7c2b09dcddb1ab0a1c3 100644
--- a/chrome/common/extensions/extension_permission_set_unittest.cc
+++ b/chrome/common/extensions/extension_permission_set_unittest.cc
@@ -173,6 +173,7 @@ TEST(ExtensionAPIPermissionTest, ComponentOnlyPermissions) {
private_perms.insert(ExtensionAPIPermission::kFileBrowserPrivate);
private_perms.insert(ExtensionAPIPermission::kMediaPlayerPrivate);
private_perms.insert(ExtensionAPIPermission::kMetricsPrivate);
+ private_perms.insert(ExtensionAPIPermission::kSystemPrivate);
private_perms.insert(ExtensionAPIPermission::kWebstorePrivate);
ExtensionAPIPermissionSet perms = info->GetAll();
@@ -184,7 +185,7 @@ TEST(ExtensionAPIPermissionTest, ComponentOnlyPermissions) {
info->GetByID(*i)->is_component_only());
}
- EXPECT_EQ(6, count);
+ EXPECT_EQ(7, count);
}
TEST(ExtensionPermissionSetTest, EffectiveHostPermissions) {
@@ -635,15 +636,16 @@ TEST(ExtensionPermissionSetTest, PermissionMessages) {
skip.insert(ExtensionAPIPermission::kExperimental);
// These are private.
- skip.insert(ExtensionAPIPermission::kWebstorePrivate);
+ skip.insert(ExtensionAPIPermission::kChromeAuthPrivate);
+ skip.insert(ExtensionAPIPermission::kChromeosInfoPrivate);
+ skip.insert(ExtensionAPIPermission::kChromePrivate);
skip.insert(ExtensionAPIPermission::kFileBrowserPrivate);
+ skip.insert(ExtensionAPIPermission::kInputMethodPrivate);
skip.insert(ExtensionAPIPermission::kMediaPlayerPrivate);
skip.insert(ExtensionAPIPermission::kMetricsPrivate);
- skip.insert(ExtensionAPIPermission::kChromeAuthPrivate);
- skip.insert(ExtensionAPIPermission::kChromePrivate);
- skip.insert(ExtensionAPIPermission::kChromeosInfoPrivate);
+ skip.insert(ExtensionAPIPermission::kSystemPrivate);
skip.insert(ExtensionAPIPermission::kWebSocketProxyPrivate);
- skip.insert(ExtensionAPIPermission::kInputMethodPrivate);
+ skip.insert(ExtensionAPIPermission::kWebstorePrivate);
// Warned as part of host permissions.
skip.insert(ExtensionAPIPermission::kDevtools);

Powered by Google App Engine
This is Rietveld 408576698