Fix a number of issues with the process handling

runtime/bin/socket_linux.cc

 // Copyright (c) 2011, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #include <arpa/inet.h>
 #include <errno.h>
 #include <netdb.h>
 #include <stdio.h>
 #include <stdlib.h>
 #include <string.h>
@@ skipping 42 matching lines @@
   }
   return -1;
 }
 
 
 intptr_t Socket::Available(intptr_t fd) {
   return FDUtils::AvailableBytes(fd);
 }
 
 
-intptr_t Socket::Read(intptr_t fd,
-                      void* buffer,
-                      intptr_t num_bytes) {
+int Socket::Read(intptr_t fd, void* buffer, intptr_t num_bytes) {
   ASSERT(fd >= 0);
-  intptr_t read_bytes = read(fd, buffer, num_bytes);
+  ssize_t read_bytes = read(fd, buffer, num_bytes);
   return read_bytes;
 }
 
 
 intptr_t Socket::Write(intptr_t fd, const void* buffer, intptr_t num_bytes) {

[Mads Ager (google), 2011/11/23 12:45:19]

You changed intptr_t to int in the interface?

[Søren Gjesse, 2011/11/23 14:50:18]

Done.

   ASSERT(fd >= 0);
-  return write(fd, buffer, num_bytes);
+  ssize_t written_bytes = write(fd, buffer, num_bytes);
+  return written_bytes;
 }
 
 
 intptr_t Socket::GetPort(intptr_t fd) {
   ASSERT(fd >= 0);
   struct sockaddr_in socket_address;
   socklen_t size = sizeof(socket_address);
   if (getsockname(fd, reinterpret_cast<struct sockaddr *>(&socket_address),
                   &size)) {
     fprintf(stderr, "Error getsockname: %s\n", strerror(errno));
@@ skipping 49 matching lines @@
   struct sockaddr clientaddr;
   socklen_t addrlen = sizeof(clientaddr);
   socket = accept(fd, &clientaddr, &addrlen);
   if (socket < 0) {
     fprintf(stderr, "Error Accept: %s\n", strerror(errno));
   } else {
     FDUtils::SetNonBlocking(socket);
   }
   return socket;
 }