Issue 8662005: [cros,login] Prevent WebUI race, when network drop-down is hided.

Issue 8662005: [cros,login] Prevent WebUI race, when network drop-down is hided. (Closed)

Created:
9 years, 1 month ago by altimofeev

Modified:
9 years ago

Reviewers:
Nikita (slow), arv (Not doing code reviews)

CC:
chromium-reviews, arv (Not doing code reviews), nkostylev+watch_chromium.org, dcheng

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

[cros,login] Prevent WebUI race, when network drop-down is hided. Also prevents useless network drop-down re-creation. BUG=chromium-os:21398 TEST="Cannot call method 'setTitle' of null" is not presented in the logs. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=111592

Created: 9 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+8 lines, -6 lines)			Patch
	M	chrome/browser/resources/chromeos/login/network_dropdown.js	View	1 2	3 chunks	+8 lines, -6 lines	0 comments	Download

Total messages: 9 (0 generated)

altimofeev

Also added checking for the case, when drop-down has already been shown. PTAL.

9 years, 1 month ago (2011-11-23 12:45:16 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/altimofeev@chromium.org/8662005/7001

9 years ago (2011-11-25 09:14:10 UTC) #5

commit-bot: I haz the power

Try job failure for 8662005-7001 (retry) (retry) on linux_rel for step "interactive_ui_tests". It's a second ...

9 years ago (2011-11-25 11:18:29 UTC) #6

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/altimofeev@chromium.org/8662005/7001

9 years ago (2011-11-25 11:41:06 UTC) #7

commit-bot: I haz the power

Try job failure for 8662005-7001 (retry) on linux_rel for step "interactive_ui_tests". It's a second try, ...

9 years ago (2011-11-25 12:55:30 UTC) #8

lgtm