Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(840)

Side by Side Diff: tools/testing/dart/test_runner.dart

Issue 8662004: Update test scripts to deal with current VM behavior on optional constructor arguments. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Address review comments Created 9 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « tools/testing/dart/test_options.dart ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2011, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2011, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 #library("test_runner"); 5 #library("test_runner");
6 6
7 #import("status_file_parser.dart"); 7 #import("status_file_parser.dart");
8 #import("test_progress.dart"); 8 #import("test_progress.dart");
9 9
10 /** 10 /**
(...skipping 20 matching lines...) Expand all
31 31
32 TestCase(this.displayName, 32 TestCase(this.displayName,
33 this.executablePath, 33 this.executablePath,
34 this.arguments, 34 this.arguments,
35 this.timeout, 35 this.timeout,
36 this.completedHandler, 36 this.completedHandler,
37 this.expectedOutcomes, 37 this.expectedOutcomes,
38 [isNegative = false]) 38 [isNegative = false])
39 : this.isNegative = isNegative { 39 : this.isNegative = isNegative {
40 if (!isNegative) { 40 if (!isNegative) {
41 isNegative = displayName.contains("NegativeTest"); 41 this.isNegative = displayName.contains("NegativeTest");
42 } 42 }
43 commandLine = executablePath; 43 commandLine = executablePath;
44 for (var arg in arguments) { 44 for (var arg in arguments) {
45 commandLine += " " + arg; 45 commandLine += " " + arg;
46 } 46 }
47 } 47 }
48 48
49 void completed() { completedHandler(this); } 49 void completed() { completedHandler(this); }
50 } 50 }
51 51
(...skipping 142 matching lines...) Expand 10 before | Expand all | Expand 10 after
194 numProcesses++; 194 numProcesses++;
195 } 195 }
196 } 196 }
197 197
198 runTest(TestCase test) { 198 runTest(TestCase test) {
199 progress.testAdded(); 199 progress.testAdded();
200 tests.add(test); 200 tests.add(test);
201 tryRunTest(); 201 tryRunTest();
202 } 202 }
203 } 203 }
OLDNEW
« no previous file with comments | « tools/testing/dart/test_options.dart ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698