Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(40)

Issue 8662002: Revive reverted CL with fix for CrOS build. (Closed)

Created:
9 years, 1 month ago by Munjal (Google)
Modified:
9 years, 1 month ago
Reviewers:
Rick Campbell
CC:
chromium-reviews, cbentzel+watch_chromium.org, darin-cc_chromium.org, Paweł Hajdan Jr.
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : '' #

Patch Set 3 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+570 lines, -24 lines) Patch
M chrome/chrome_common.gypi View 1 2 1 chunk +3 lines, -0 lines 0 comments Download
M chrome/chrome_tests.gypi View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M chrome/common/net/gaia/gaia_auth_consumer.h View 1 2 1 chunk +5 lines, -0 lines 0 comments Download
M chrome/common/net/gaia/gaia_auth_fetcher.h View 1 2 11 chunks +60 lines, -1 line 0 comments Download
M chrome/common/net/gaia/gaia_auth_fetcher.cc View 1 2 18 chunks +224 lines, -3 lines 0 comments Download
M chrome/common/net/gaia/gaia_auth_fetcher_unittest.cc View 1 2 6 chunks +224 lines, -0 lines 0 comments Download
M chrome/common/net/gaia/gaia_urls.h View 1 2 2 chunks +10 lines, -0 lines 0 comments Download
M chrome/common/net/gaia/gaia_urls.cc View 1 2 3 chunks +35 lines, -0 lines 0 comments Download
A + chrome/common/net/gaia/oauth2_access_token_consumer.h View 0 chunks +-1 lines, --1 lines 0 comments Download
A + chrome/common/net/gaia/oauth2_access_token_fetcher.h View 1 1 chunk +2 lines, -2 lines 0 comments Download
A + chrome/common/net/gaia/oauth2_access_token_fetcher.cc View 1 2 chunks +7 lines, -11 lines 0 comments Download
A + chrome/common/net/gaia/oauth2_access_token_fetcher_unittest.cc View 1 chunk +0 lines, -8 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Munjal (Google)
Rick, this is just a revival of the earlier CL. I just made one change: ...
9 years, 1 month ago (2011-11-23 06:06:30 UTC) #1
Rick Campbell
LGTM with the nit that we spoke of elsewhere regarding the use of Report in ...
9 years, 1 month ago (2011-11-23 21:47:47 UTC) #2
Rick Campbell
9 years, 1 month ago (2011-11-23 21:49:37 UTC) #3
LGTM

I see that you got that change in as well.

Powered by Google App Engine
This is Rietveld 408576698