remoting/host/host_secret.h - Issue 8662001: Remove AccessVerifier interface.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: remoting/host/host_secret.h

Issue 8662001: Remove AccessVerifier interface. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: - Created 9 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
(Empty)
	1 // Copyright (c) 2011 The Chromium Authors. All rights reserved.

	2 // Use of this source code is governed by a BSD-style license that can be

	3 // found in the LICENSE file.

	4

	5 #include <string>

	6

	7 namespace remoting {

	8

	9 // Generates random host secret.q
	Wez 2011/11/29 05:58:47 Is there supposed to be a 'q' on the end of this l Is there supposed to be a 'q' on the end of this line? Sergey Ulanov 2011/11/29 18:52:01 Done. Show quoted text On 2011/11/29 05:58:47, Wez wrote: > Is there supposed to be a 'q' on the end of this line? Done.
	10 std::string GenerateRandomHostSecret();
	Wez 2011/11/29 05:58:47 Call this GenerateSupportHostSecret()? Random see Call this GenerateSupportHostSecret()? Random seems implicit in it being "generated", and we need to make it clear that this secret is nothing to do with the host private key, nor Me2Me PIN. Sergey Ulanov 2011/11/29 18:52:01 Done. Show quoted text On 2011/11/29 05:58:47, Wez wrote: > Call this GenerateSupportHostSecret()? Random seems implicit in it being > "generated", and we need to make it clear that this secret is nothing to do with > the host private key, nor Me2Me PIN. Done.
	11

	12 } // namespace remoting

OLD	NEW