Fire CanPlayThrough immediately for local and streaming media files

media/base/pipeline_impl.h

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // Implementation of Pipeline & PipelineStatusNotification (an async-to-sync
 // callback adapter).
 
 #ifndef MEDIA_BASE_PIPELINE_IMPL_H_
 #define MEDIA_BASE_PIPELINE_IMPL_H_
 
@@ skipping 108 matching lines @@
   virtual float GetVolume() const OVERRIDE;
   virtual void SetVolume(float volume) OVERRIDE;
   virtual void SetPreload(Preload preload) OVERRIDE;
   virtual base::TimeDelta GetCurrentTime() const OVERRIDE;
   virtual base::TimeDelta GetBufferedTime() OVERRIDE;
   virtual base::TimeDelta GetMediaDuration() const OVERRIDE;
   virtual int64 GetBufferedBytes() const OVERRIDE;
   virtual int64 GetTotalBytes() const OVERRIDE;
   virtual void GetNaturalVideoSize(gfx::Size* out_size) const OVERRIDE;
   virtual bool IsStreaming() const OVERRIDE;
-  virtual bool IsLoaded() const OVERRIDE;
+  virtual bool IsLocalSource() const OVERRIDE;
   virtual PipelineStatistics GetStatistics() const OVERRIDE;
 
   void SetClockForTesting(Clock* clock);
 
  private:
   friend class MediaLog;
 
   // Pipeline states, as described above.
   enum State {
     kCreated,
@@ skipping 54 matching lines @@
   virtual void SetError(PipelineStatus error) OVERRIDE;
   virtual base::TimeDelta GetTime() const OVERRIDE;
   virtual base::TimeDelta GetDuration() const OVERRIDE;
   virtual void SetTime(base::TimeDelta time) OVERRIDE;
   virtual void SetDuration(base::TimeDelta duration) OVERRIDE;
   virtual void SetBufferedTime(base::TimeDelta buffered_time) OVERRIDE;
   virtual void SetTotalBytes(int64 total_bytes) OVERRIDE;
   virtual void SetBufferedBytes(int64 buffered_bytes) OVERRIDE;
   virtual void SetNaturalVideoSize(const gfx::Size& size) OVERRIDE;
   virtual void SetStreaming(bool streamed) OVERRIDE;
-  virtual void SetLoaded(bool loaded) OVERRIDE;
   virtual void SetNetworkActivity(bool is_downloading_data) OVERRIDE;
   virtual void NotifyEnded() OVERRIDE;
   virtual void DisableAudioRenderer() OVERRIDE;
   virtual void SetCurrentReadPosition(int64 offset) OVERRIDE;
   virtual int64 GetCurrentReadPosition() OVERRIDE;
 
   // Callback executed by filters upon completing initialization.
   void OnFilterInitialize();
 
   // Callback executed by filters upon completing Play(), Pause(), or Stop().
@@ skipping 163 matching lines @@
 
   // Amount of available buffered data.  Set by filters.
   int64 buffered_bytes_;
 
   // Total size of the media.  Set by filters.
   int64 total_bytes_;
 
   // Video's natural width and height.  Set by filters.
   gfx::Size natural_size_;
 
-  // Sets by the filters to indicate whether the data source is a streaming
+  // Set by the filters to indicate whether the data source is a streaming

[acolwell GONE FROM CHROMIUM, 2011/11/30 19:26:11]

Update comment to reflect that this comes from the Demuxer and not filters.

[vrk (LEFT CHROMIUM), 2011/12/01 02:11:35]

Done.

   // source.
   bool streaming_;
 
-  // Sets by the filters to indicate whether the data source is a fully
-  // loaded source.
-  bool loaded_;
+  // Indicates whether the data source is local, such as a local media file
+  // from disk or a local webcam stream.
+  bool local_source_;
 
   // Current volume level (from 0.0f to 1.0f).  This value is set immediately
   // via SetVolume() and a task is dispatched on the message loop to notify the
   // filters.
   float volume_;
 
   // Current value of preload attribute. This value is set immediately via
   // SetPreload() and a task is dispatched on the message loop to notify the
   // filters.
   Preload preload_;
@@ skipping 90 matching lines @@
   bool is_downloading_data_;
 
   FRIEND_TEST_ALL_PREFIXES(PipelineImplTest, GetBufferedTime);
 
   DISALLOW_COPY_AND_ASSIGN(PipelineImpl);
 };
 
 }  // namespace media
 
 #endif  // MEDIA_BASE_PIPELINE_IMPL_H_