Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(20)

Issue 8660001: Remove obsolete usage of TOUCH_UI. (Closed)

Created:
9 years, 1 month ago by Emmanuel Saint-loubert-Bié
Modified:
9 years, 1 month ago
Reviewers:
Nico
CC:
chromium-reviews, sadrul, brettw-cc_chromium.org, DaveMoore
Visibility:
Public.

Description

Remove obsolete usage of TOUCH_UI. BUG=105046 TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=111287

Patch Set 1 #

Total comments: 2

Patch Set 2 : Report Aura as a different config. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -4 lines) Patch
M base/linux_util.cc View 1 1 chunk +2 lines, -2 lines 0 comments Download
M base/message_loop.h View 1 chunk +1 line, -1 line 0 comments Download
M base/message_loop.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 6 (0 generated)
Emmanuel Saint-loubert-Bié
Hi Nico, More of the same cleanup. Thanks, -- Emmanuel
9 years, 1 month ago (2011-11-22 22:07:16 UTC) #1
Nico
LGTM if the crash report id change is intentional http://codereview.chromium.org/8660001/diff/1/base/linux_util.cc File base/linux_util.cc (left): http://codereview.chromium.org/8660001/diff/1/base/linux_util.cc#oldcode135 base/linux_util.cc:135: ...
9 years, 1 month ago (2011-11-22 22:25:34 UTC) #2
Emmanuel Saint-loubert-Bié
I think it makes sense to report Aura for now. One day when we have ...
9 years, 1 month ago (2011-11-22 22:36:27 UTC) #3
Nico
still lgtm
9 years, 1 month ago (2011-11-22 22:44:15 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/saintlou@chromium.org/8660001/3001
9 years, 1 month ago (2011-11-22 23:11:37 UTC) #5
commit-bot: I haz the power
9 years, 1 month ago (2011-11-23 02:07:46 UTC) #6
Change committed as 111287

Powered by Google App Engine
This is Rietveld 408576698