base/utf_offset_string_conversions.h - Issue 8659047: De-duplicate common code from StringPiece, StringPiece16, and their tests.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: base/utf_offset_string_conversions.h

Issue 8659047: De-duplicate common code from StringPiece, StringPiece16, and their tests. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Fix two bugs introduced during refactoring. Created 9 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: base/utf_offset_string_conversions.h

diff --git a/base/utf_offset_string_conversions.h b/base/utf_offset_string_conversions.h

index c2faf3a491599cf33648d06380fd8525876d7868..97b641edda8b49a9a9797ec4cd08966f2400c277 100644

--- a/base/utf_offset_string_conversions.h

+++ b/base/utf_offset_string_conversions.h

@@ -11,11 +11,7 @@

#include "base/base_export.h"

#include "base/string16.h"

-namespace base {

-class StringPiece;

-class StringPiece16;

+#include "base/string_piece.h"

// Like the conversions in utf_string_conversions.h, but also takes one or more

// offsets (|offset[s]_for_adjustment|) into the source strings, each offset

« no previous file with comments | « base/string_piece_unittest.cc ('k') | no next file » | no next file with comments »