base/logging.h - Issue 8659047: De-duplicate common code from StringPiece, StringPiece16, and their tests.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: base/logging.h

Issue 8659047: De-duplicate common code from StringPiece, StringPiece16, and their tests. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Fix two bugs introduced during refactoring. Created 9 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: base/logging.h

diff --git a/base/logging.h b/base/logging.h

index 94a82addfd0de4733e2ee42630edc508134b1ee9..9c660fa0ccfb61f8b9befbcf449eeda62cec12ab 100644

--- a/base/logging.h

+++ b/base/logging.h

@@ -983,7 +983,8 @@ inline std::ostream& operator<<(std::ostream& out, const std::wstring& wstr) {

namespace base {

-class StringPiece;

+template <typename STRING_TYPE> class BasicStringPiece;

+typedef BasicStringPiece<std::string> StringPiece;

// Allows StringPiece to be logged.

BASE_EXPORT std::ostream& operator<<(std::ostream& o, const StringPiece& piece);

« no previous file with comments | « base/i18n/case_conversion.h ('k') | base/string_piece.h » ('j') | no next file with comments »