Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2400)

Unified Diff: content/renderer/media/webrtc_audio_device_impl.cc

Issue 8659040: There is a racing between SyncSocket::Receive in audio_thread_ and SyncSocket::Close in renderer ... (Closed) Base URL: http://src.chromium.org/svn/trunk/src/
Patch Set: update Created 9 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/renderer/media/audio_input_device.cc ('k') | content/renderer/renderer_webaudiodevice_impl.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/renderer/media/webrtc_audio_device_impl.cc
diff --git a/content/renderer/media/webrtc_audio_device_impl.cc b/content/renderer/media/webrtc_audio_device_impl.cc
index 2d5bd365a245b2fe2a311ea908dee7c24f34c106..1039fd25f63a883443bead6b3aa4100138c398cd 100644
--- a/content/renderer/media/webrtc_audio_device_impl.cc
+++ b/content/renderer/media/webrtc_audio_device_impl.cc
@@ -597,8 +597,9 @@ int32_t WebRtcAudioDeviceImpl::StopPlayout() {
// webrtc::VoiceEngine assumes that it is OK to call Stop() just in case.
return 0;
}
- playing_ = !audio_output_device_->Stop();
- return (!playing_ ? 0 : -1);
+ audio_output_device_->Stop();
+ playing_ = false;
+ return 0;
}
bool WebRtcAudioDeviceImpl::Playing() const {
@@ -646,8 +647,9 @@ int32_t WebRtcAudioDeviceImpl::StopRecording() {
// webrtc::VoiceEngine assumes that it is OK to call Stop() just in case.
return 0;
}
- recording_ = !audio_input_device_->Stop();
- return (!recording_ ? 0 : -1);
+ audio_input_device_->Stop();
+ recording_ = false;
+ return 0;
}
bool WebRtcAudioDeviceImpl::Recording() const {
« no previous file with comments | « content/renderer/media/audio_input_device.cc ('k') | content/renderer/renderer_webaudiodevice_impl.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698