IME (input method editor) support for Aura, part 1 of 3: Add ui/base/ime/ classes

base/event_types.h

Index: base/event_types.h
diff --git a/base/event_types.h b/base/event_types.h
index a1b78f6db2cff8fd72e9f2434bede7662aa04ccd..7fe95ba34721bd96bb39a285c59f6ee332af6a6f 100644
--- a/base/event_types.h
+++ b/base/event_types.h
@@ -17,6 +17,7 @@ union WaylandEvent;
 }
 }
 #elif defined(USE_X11)
+#include <X11/Xdefs.h>  // for XID
 typedef union _XEvent XEvent;
 #endif
 
@@ -25,12 +26,16 @@ namespace base {
 // Cross platform typedefs for native event types.
 #if defined(OS_WIN)
 typedef MSG NativeEvent;
+typedef HWND NativeWindow;

[brettw, 2011/12/02 03:49:17]

Why not use ui/gfx/native_widget_types.h instead of modifying this?

[Yusuke Sato, 2011/12/02 04:02:25]

This is because ui::InputMethod, which is designed to depend on neither Views
nor Aura, requires a real system window handle.

If I understand correctly, using gfx::NativeWindow introduces Aura dependency
since gfx::NativeWindow is typedefed to aura::Window* when USE_AURA is #defined
(on both Windows and Linux).

 #elif defined(USE_WAYLAND)
 typedef wayland::WaylandEvent* NativeEvent;
+// TODO: typedef NativeWindow.
 #elif defined(USE_X11)
 typedef XEvent* NativeEvent;
+typedef XID NativeWindow;
 #else
 typedef void* NativeEvent;
+typedef void* NativeWindow;
 #endif
 
 } // namespace base