Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(240)

Unified Diff: ui/base/ime/text_input_client.h

Issue 8659033: IME (input method editor) support for Aura, part 1 of 3: Add ui/base/ime/ classes (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: rebase, review fix Created 9 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « ui/base/ime/mock_input_method.cc ('k') | ui/ui.gyp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ui/base/ime/text_input_client.h
diff --git a/ui/base/ime/text_input_client.h b/ui/base/ime/text_input_client.h
index 01f5152bf63394fc82ba12d887413c2c10a3af6f..4d1030954c1579492b28dda775d581232a2f6ba1 100644
--- a/ui/base/ime/text_input_client.h
+++ b/ui/base/ime/text_input_client.h
@@ -60,9 +60,15 @@ class UI_EXPORT TextInputClient {
// TEXT_INPUT_TYPE_NONE at runtime.
virtual ui::TextInputType GetTextInputType() const = 0;
- // Returns current caret (insertion point) bounds relative to the View’s
+ // Returns current caret (insertion point) bounds relative to the screen
// coordinates. If there is selection, then the selection bounds will be
// returned.
+ // TODO(yusukes): Currently views::NativeTextfieldViews which implements this
+ // interface returns its view's coordinates. We should to do the following:
+ // 1) Modify NativeTextfieldViews so it returns screen coordinates.
+ // 2) Remove view-to-screen coordinates conversion code in InputMethodBridge.
+ // 3) Modify InputMethodWin. It requires a rect in toplevel window's
+ // coordinates instead of screen.
virtual gfx::Rect GetCaretBounds() = 0;
// Returns true if there is composition text.
« no previous file with comments | « ui/base/ime/mock_input_method.cc ('k') | ui/ui.gyp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698