Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(580)

Issue 8659015: Revert 110948 - Add support for stripping Chrome tests. (Closed)

Created:
9 years ago by DaveMoore
Modified:
9 years ago
Reviewers:
DaveMoore
CC:
chromium-reviews
Visibility:
Public.

Description

Revert 110948 - Add support for stripping Chrome tests. The chromeos-chrome ebuild strips Chrome tests after the build, but it can run significantly faster if we strip them during the build. This changelist reduces the time it takes to build Chrome by allowing developers to remove unnecessary debug symbols. Performance comparison on z600 LOCAL_SOURCE build: Before: 24m31s (257m04s user, 23m19s sys) After: 20m55s (236m12s user, 22m10s sys) Companion CL for updating Chrome OS to use strip_tests by default is here: https://gerrit.chromium.org/gerrit/11517 BUG=chromium-os:22844 TEST=Build with and without debug symbols. Confirm speed difference. Review URL: http://codereview.chromium.org/8526022 TBR=davemoore@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=111778

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -13 lines) Patch
M build/common.gypi View 2 chunks +0 lines, -5 lines 0 comments Download
M chrome/chrome_tests.gypi View 1 chunk +0 lines, -8 lines 0 comments Download

Messages

Total messages: 1 (0 generated)
DaveMoore
9 years ago (2011-11-28 21:52:41 UTC) #1

          

Powered by Google App Engine
This is Rietveld 408576698