chrome/browser/ui/views/tab_contents/native_tab_contents_container_aura.cc - Issue 8659014: Check that we have a focus manager in aura before trying to set focus.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/views/tab_contents/native_tab_contents_container_aura.cc

Issue 8659014: Check that we have a focus manager in aura before trying to set focus. (Closed) Base URL: http://git.chromium.org/git/chromium.git@trunk

Patch Set: update, add print preview handler unittest also, same fix. Created 9 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/ui/views/tab_contents/native_tab_contents_container_aura.cc

diff --git a/chrome/browser/ui/views/tab_contents/native_tab_contents_container_aura.cc b/chrome/browser/ui/views/tab_contents/native_tab_contents_container_aura.cc

index d010d6eefe39d2e28f56d21511723b4acc429ca6..088b1dddb43d30c08e7b989b0373530083954019 100644

--- a/chrome/browser/ui/views/tab_contents/native_tab_contents_container_aura.cc

+++ b/chrome/browser/ui/views/tab_contents/native_tab_contents_container_aura.cc

@@ -113,7 +113,7 @@ void NativeTabContentsContainerAura::RequestFocus() {

// that should also have focus, RequestFocus() is invoked one the

// TabContentsContainer. In order to make sure OnFocus() is invoked we need

// to clear the focus before hands.

- {

+ if (GetFocusManager()) {

// Disable notifications. Clear focus will assign the focus to the main

// browser window. Because this change of focus was not user requested,

// don't send it to listeners.

« no previous file with comments | « no previous file | chrome/browser/ui/webui/print_preview_handler_unittest.cc » ('j') | no next file with comments »