Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1105)

Unified Diff: chrome/browser/extensions/component_loader.h

Issue 8659002: Adding the --load-component-extension flag. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Multiptle values supported. Created 9 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/component_loader.h
diff --git a/chrome/browser/extensions/component_loader.h b/chrome/browser/extensions/component_loader.h
index ec7726975f7ae09c1253f8025e5b8858396beb75..5de83d321bd1a174593e70c16374c80ebb46221f 100644
--- a/chrome/browser/extensions/component_loader.h
+++ b/chrome/browser/extensions/component_loader.h
@@ -41,10 +41,17 @@ class ComponentLoader : public content::NotificationObserver {
const Extension* Add(int manifest_resource_id,
const FilePath& root_directory);
+ // Loads a component extension from file system.
+ const Extension* AddFromCommandLine(const FilePath& path);
Aaron Boodman 2011/11/29 05:32:25 The fact that this comes from a command line is a
SeRya 2011/11/29 21:31:00 Renamed to AddOrReplace
+
// Unloads a component extension and removes it from the list of component
// extensions to be loaded.
void Remove(const FilePath& root_directory);
+ // Removes a component extension from the list of component
+ // extensions to be loaded.
Aaron Boodman 2011/11/29 05:32:25 Nit: it looks like "extensions" fits on the previo
SeRya 2011/11/29 21:31:00 Since now comment for the prev method reflects thi
+ void Remove(const std::string& id);
+
// Adds the default component extensions.
//
// Component extension manifests must contain a 'key' property with a unique
@@ -96,6 +103,9 @@ class ComponentLoader : public content::NotificationObserver {
// Add the enterprise webstore extension, or reload it if already loaded.
void AddOrReloadEnterpriseWebStore();
+ // Determine the extension id and unload the extension.
Aaron Boodman 2011/11/29 05:32:25 Comment is incorrect, nothing is unloaded here.
SeRya 2011/11/29 21:31:00 Fixed.
+ std::string GenerateId(const base::DictionaryValue* manifest);
Aaron Boodman 2011/11/29 05:32:25 Nit: capitalize "ID".
SeRya 2011/11/29 21:31:00 It is 'Id' everywhere except a few unit tests. Inc
+
PrefService* prefs_;
PrefService* local_state_;
« no previous file with comments | « no previous file | chrome/browser/extensions/component_loader.cc » ('j') | chrome/browser/extensions/component_loader.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698