chrome/test/data/extensions/good/Extensions/mndnfokpggljbaajbnioimlmbfngpief/manifest.json - Issue 8659002: Adding the --load-component-extension flag.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/test/data/extensions/good/Extensions/mndnfokpggljbaajbnioimlmbfngpief/manifest.json

Issue 8659002: Adding the --load-component-extension flag. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Code review fix. Created 9 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch | Annotate | Revision Log

OLD	NEW
(Empty)
	1 {

	2 "key": "MIGfMA0GCSqGSIb3DQEBAQUAA4GNADCBiQKBgQDQcByy+eN9jzazWF/DPn7NW47sW7lgmp k6eKc0BQM18q8hvEM3zNm2n7HkJv/R6fU+X5mtqkDuKvq5skF6qqUF4oEyaleWDFhd1xFwV7JV+/DU7b Z00w2+6gzqsabkerFpoP33ZRIw7OviJenP0c0uWqDWF8EGSyMhB3txqhOtiQIDAQAB",
	Aaron Boodman 2011/12/06 19:43:35 I think that if you put this file here, it will br I think that if you put this file here, it will break other unit tests that expect a certain number of extensions in this directory. Even if not, it's a bit weird as this directory is used to test a specific feature (it's badly named), and this test has nothing to do with that feature. Please move this to test/data/extensions/extension_with_key/ SeRya 2011/12/06 22:19:37 Moved to chrome/test/data/extensions/override_comp Show quoted text On 2011/12/06 19:43:35, Aaron Boodman wrote: > I think that if you put this file here, it will break other unit tests that > expect a certain number of extensions in this directory. > > Even if not, it's a bit weird as this directory is used to test a specific > feature (it's badly named), and this test has nothing to do with that feature. > > Please move this to test/data/extensions/extension_with_key/ Moved to chrome/test/data/extensions/override_component_extension/manifest.json
	3 "name": "Bookmark Manager",
	Aaron Boodman 2011/12/06 19:43:35 Most of these keys are irrelevant to the test. You Most of these keys are irrelevant to the test. You can remove everything except the name, version, and key. Please make the name something descriptive, like "Extension with key" SeRya 2011/12/06 22:19:37 Done. Show quoted text On 2011/12/06 19:43:35, Aaron Boodman wrote: > Most of these keys are irrelevant to the test. You can remove everything except > the name, version, and key. Please make the name something descriptive, like > "Extension with key" Done.
	4 "version": "0.1",

	5 "manifest_version": 2,

	6 "description": "Bookmark Manager",

	7 "icons": {

	8 // The favicon is loaded directly from resources.pak.

	9 },

	10 "incognito" : "split",

	11 "permissions": [

	12 "bookmarks",

	13 "experimental",

	14 "tabs",

	15 "chrome://favicon/",

	16 "chrome://resources/"

	17 ],

	18 "chrome_url_overrides": {

	19 "bookmarks": "main.html"

	20 },

	21 "content_security_policy":

	22 "object-src 'none'; script-src chrome://resources chrome-extension://mndnfok pggljbaajbnioimlmbfngpief 'self'"

	23 }

OLD	NEW

« chrome/browser/profiles/profile_impl.cc ('K') | « chrome/common/extensions/extension_file_util.cc ('k') | no next file » | no next file with comments »