Adding the --load-component-extension flag.

chrome/browser/extensions/component_loader_unittest.cc

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include <string>
 
 #include "chrome/browser/extensions/component_loader.h"
 
 #include "base/file_util.h"
 #include "base/path_service.h"
 #include "chrome/browser/extensions/test_extension_service.h"
 #include "chrome/common/chrome_paths.h"
 #include "chrome/common/extensions/extension.h"
 #include "chrome/common/pref_names.h"
 #include "chrome/test/base/testing_pref_service.h"
 #include "testing/gtest/include/gtest/gtest.h"
 
 namespace {
 
 class MockExtensionService : public TestExtensionService {
  private:
   bool ready_;
   ExtensionList extension_list_;
+  size_t unloaded_;

[Aaron Boodman, 2011/12/05 22:11:26]

This is not a good name. It should be unloaded_count_ to match the getter.

[SeRya, 2011/12/06 08:19:27]

Done.

+
+  bool find(std::string id) {

[Aaron Boodman, 2011/12/05 22:11:26]

Methods are supposed to be ordered before fields.

[SeRya, 2011/12/06 08:19:27]

Done.

+    for (ExtensionList::iterator it = extension_list_.begin();
+         it != extension_list_.end();
+         ++it)
+      if ((*it)->id() == id)
+        return true;
+
+    return false;
+  }
 
  public:
-  MockExtensionService() : ready_(false) {
+  MockExtensionService() : ready_(false), unloaded_(0) {
   }
 
   virtual void AddExtension(const Extension* extension) OVERRIDE {
+    ASSERT_FALSE(find(extension->id()));
     // ExtensionService must become the owner of the extension object.
     extension_list_.push_back(extension);
   }
 
   virtual void UnloadExtension(
       const std::string& extension_id,
       extension_misc::UnloadedExtensionReason reason) OVERRIDE {
+    ASSERT_TRUE(find(extension_id));
     // Remove the extension with the matching id.
     for (ExtensionList::iterator it = extension_list_.begin();
          it != extension_list_.end();
          ++it) {
       if ((*it)->id() == extension_id) {
         extension_list_.erase(it);
+        unloaded_++;
         return;
       }
     }
   }
 
   virtual bool is_ready() OVERRIDE {
     return ready_;
   }
 
   virtual const ExtensionList* extensions() const OVERRIDE {
     return &extension_list_;
   }
 
   void set_ready(bool ready) {
     ready_ = ready;
   }
 
+  size_t get_unloaded_count() const {

[Aaron Boodman, 2011/12/05 22:11:26]

getters in Chrome do not have the 'get_' prefix.

[SeRya, 2011/12/06 08:19:27]

Done.

+    return unloaded_;
+  }
+
   void clear_extension_list() {
     extension_list_.clear();
   }
 };
 
 }  // namespace
 
 namespace extensions {
 
 class ComponentLoaderTest : public testing::Test {
@@ skipping 32 matching lines @@
  protected:
   MockExtensionService extension_service_;
   TestingPrefService prefs_;
   ComponentLoader component_loader_;
 
   // The root directory of the text extension.
   FilePath extension_path_;
 
   // The contents of the text extension's manifest file.
   std::string manifest_contents_;
+
+  FilePath get_extension_path(std::string name) {

[Aaron Boodman, 2011/12/05 22:11:26]

Since this does significant work, it should be named like GetExtensionPath().
Only getters are named like foo_bar().

[SeRya, 2011/12/06 08:19:27]

Done.

+    FilePath test_data_dir;
+    PathService::Get(chrome::DIR_TEST_DATA, &test_data_dir);
+    return
+        test_data_dir.AppendASCII("extensions")

[Aaron Boodman, 2011/12/05 22:11:26]

Line 135 looks like it can fit with line 134.

[SeRya, 2011/12/06 08:19:27]

Done.

+                     .AppendASCII("good")
+                     .AppendASCII("Extensions")
+                     .AppendASCII(name.c_str());
+
+  }
 };
 
 TEST_F(ComponentLoaderTest, ParseManifest) {
   scoped_ptr<DictionaryValue> manifest;
 
   // Test invalid JSON.
   manifest.reset(
       component_loader_.ParseManifest("{ 'test': 3 } invalid"));
   ASSERT_EQ((DictionaryValue*)NULL, manifest.get());
 
@@ skipping 120 matching lines @@
   component_loader_.AddDefaultComponentExtensions();
   component_loader_.LoadAll();
   ASSERT_EQ(default_count + 1, extension_service_.extensions()->size());
 
   // Number of loaded extensions should be the same after changing the pref.
   prefs_.SetUserPref(prefs::kEnterpriseWebStoreURL,
                      Value::CreateStringValue("http://www.google.de"));
   ASSERT_EQ(default_count + 1, extension_service_.extensions()->size());
 }
 
+TEST_F(ComponentLoaderTest, AddOrReplace) {
+  ASSERT_EQ(0U, component_loader_.GetRegisteredExtensionsCount());

[Aaron Boodman, 2011/12/05 22:11:26]

Chrome uses lower-case 'u'.

[SeRya, 2011/12/06 08:19:27]

Done.

+  component_loader_.AddDefaultComponentExtensions();
+  size_t const default_count = component_loader_.GetRegisteredExtensionsCount();
+
+  // Replace a default component extension.
+  component_loader_.AddOrReplace(get_extension_path("hhaomjibdihmijegdhdafkllkbggdgoj"));

[Aaron Boodman, 2011/12/05 22:11:26]

line length

[SeRya, 2011/12/06 08:19:27]

Done.

+  ASSERT_EQ(default_count,
+            component_loader_.GetRegisteredExtensionsCount());
+
+  // Add a new component extension.
+  component_loader_.AddOrReplace(
+      get_extension_path("hpiknbiabeeppbpihjehijgoemciehgk/2"));
+  ASSERT_EQ(default_count + 1,
+            component_loader_.GetRegisteredExtensionsCount());
+
+  extension_service_.set_ready(true);
+  component_loader_.LoadAll();
+
+  ASSERT_EQ(default_count + 1, extension_service_.extensions()->size());
+  ASSERT_EQ(0U, extension_service_.get_unloaded_count());
+
+  // replace loaded component extension.
+  component_loader_.AddOrReplace(get_extension_path("hhaomjibdihmijegdhdafkllkbggdgoj"));

[Aaron Boodman, 2011/12/05 22:11:26]

line length

[SeRya, 2011/12/06 08:19:27]

Done.

+  ASSERT_EQ(default_count + 1, extension_service_.extensions()->size());
+  ASSERT_EQ(1U, extension_service_.get_unloaded_count());
+}
+
 }  // namespace extensions