Issue 8658009: views: Move tabbed_pane directory to ui/views/controls/.

Issue 8658009: views: Move tabbed_pane directory to ui/views/controls/. (Closed)

Created:
9 years ago by tfarina

Modified:
9 years ago

Reviewers:
M-A Ruel

CC:
chromium-reviews, tfarina, Paweł Hajdan Jr., dhollowa

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

views: Move tabbed_pane directory to ui/views/controls/. BUG=104039 R=maruel@chromium.org TBR=ben@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=111612

Patch Set 2 : fix native_tabbed_pane_wrapper.h #

Created: 9 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+52 lines, -1328 lines)			Patch
M	chrome/browser/ui/views/collected_cookies_win.h	View		1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/ui/views/collected_cookies_win.cc	View		2 chunks	+1 line, -1 line	0 comments	Download
A +	ui/views/controls/tabbed_pane/native_tabbed_pane_gtk.h	View		2 chunks	+4 lines, -4 lines	0 comments	Download
A +	ui/views/controls/tabbed_pane/native_tabbed_pane_gtk.cc	View		2 chunks	+3 lines, -3 lines	0 comments	Download
A +	ui/views/controls/tabbed_pane/native_tabbed_pane_win.h	View		2 chunks	+4 lines, -4 lines	0 comments	Download
A +	ui/views/controls/tabbed_pane/native_tabbed_pane_win.cc	View		2 chunks	+3 lines, -3 lines	0 comments	Download
A +	ui/views/controls/tabbed_pane/native_tabbed_pane_wrapper.h	View	1	2 chunks	+8 lines, -3 lines	0 comments	Download
A +	ui/views/controls/tabbed_pane/tabbed_pane.h	View		2 chunks	+3 lines, -3 lines	0 comments	Download
A +	ui/views/controls/tabbed_pane/tabbed_pane.cc	View		1 chunk	+3 lines, -3 lines	0 comments	Download
A +	ui/views/controls/tabbed_pane/tabbed_pane_listener.h	View		2 chunks	+3 lines, -3 lines	0 comments	Download
A +	ui/views/controls/tabbed_pane/tabbed_pane_unittest.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	ui/views/examples/examples_main.cc	View		2 chunks	+1 line, -1 line	0 comments	Download
M	ui/views/examples/tabbed_pane_example.h	View		1 chunk	+1 line, -1 line	0 comments	Download
M	ui/views/examples/tabbed_pane_example.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	ui/views/focus/focus_manager_unittest.cc	View		1 chunk	+2 lines, -2 lines	0 comments	Download
M	ui/views/focus/focus_traversal_unittest.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
D	views/controls/tabbed_pane/native_tabbed_pane_gtk.h	View		1 chunk	+0 lines, -69 lines	0 comments	Download
D	views/controls/tabbed_pane/native_tabbed_pane_gtk.cc	View		1 chunk	+0 lines, -233 lines	0 comments	Download
D	views/controls/tabbed_pane/native_tabbed_pane_win.h	View		1 chunk	+0 lines, -92 lines	0 comments	Download
D	views/controls/tabbed_pane/native_tabbed_pane_win.cc	View		1 chunk	+0 lines, -407 lines	0 comments	Download
D	views/controls/tabbed_pane/native_tabbed_pane_wrapper.h	View		1 chunk	+0 lines, -74 lines	0 comments	Download
D	views/controls/tabbed_pane/tabbed_pane.h	View		1 chunk	+0 lines, -105 lines	0 comments	Download
D	views/controls/tabbed_pane/tabbed_pane.cc	View		1 chunk	+0 lines, -142 lines	0 comments	Download
D	views/controls/tabbed_pane/tabbed_pane_listener.h	View		1 chunk	+0 lines, -24 lines	0 comments	Download
D	views/controls/tabbed_pane/tabbed_pane_unittest.cc	View		1 chunk	+0 lines, -135 lines	0 comments	Download
M	views/views.gyp	View		6 chunks	+12 lines, -12 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

M-A Ruel

lgtm http://codereview.chromium.org/8658009/diff/1001/ui/views/controls/tabbed_pane/native_tabbed_pane_gtk.cc File ui/views/controls/tabbed_pane/native_tabbed_pane_gtk.cc (right): http://codereview.chromium.org/8658009/diff/1001/ui/views/controls/tabbed_pane/native_tabbed_pane_gtk.cc#newcode22 ui/views/controls/tabbed_pane/native_tabbed_pane_gtk.cc:22: namespace views { Will you change the namespace ...

9 years ago (2011-11-25 19:09:32 UTC) #2

tfarina

9 years ago (2011-11-25 19:18:24 UTC) #3

http://codereview.chromium.org/8658009/diff/1001/ui/views/controls/tabbed_pan...
File ui/views/controls/tabbed_pane/native_tabbed_pane_gtk.cc (right):

http://codereview.chromium.org/8658009/diff/1001/ui/views/controls/tabbed_pan...
ui/views/controls/tabbed_pane/native_tabbed_pane_gtk.cc:22: namespace views {
On 2011/11/25 19:09:32, Marc-Antoine Ruel wrote:
> Will you change the namespace to ui::views?

Ben said in the email to keep the views namespace for now. He didn't say
anything about wrapping the current namespace into the ui namespace.

http://codereview.chromium.org/8658009/diff/1001/views/views.gyp
File views/views.gyp (right):

http://codereview.chromium.org/8658009/diff/1001/views/views.gyp#newcode255
views/views.gyp:255:
'../ui/views/controls/tabbed_pane/native_tabbed_pane_gtk.cc',
On 2011/11/25 19:09:32, Marc-Antoine Ruel wrote:
> I guess this project will be moved eventually under ui?

Yes, when everything is under ui/views/ I'll create a gyp file for it (probably
an ui/views/views.gypi or ui/ui_views.gypi, I'm not sure yet). Unless you have a
better idea ;)

Expand Messages | Collapse Messages